Properly set multiline custom CA Bundle #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
apodhrad
commented
May 9, 2024
•
apodhrad
commented
- 2.9 branch Properly set multiline custom CA Bundle #1439
- 2.8 branch Properly set multiline custom CA Bundle #1440
Signed-off-by: Andrej Podhradsky <apodhrad@redhat.com>
Robot Results
|
|
Hi @mattmahoneyrh @asanzgom this implementation works for multiline as well as single line strings |
|
We also need to merge this change to 2.8 and 2.9 |
|
Ran this PR after setting the custom CA bundle with configure-trusted-ca-bundle-dis.sh, all trusted-ca-bundle test cases passed (tag: ODS-2638) when run from localhost. |
mattmahoneyrh
approved these changes
May 9, 2024
|
asanzgom
approved these changes
May 10, 2024
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.