Properly set multiline custom CA Bundle #1440
Conversation
apodhrad
requested review from
mattmahoneyrh,
manosnoam and
asanzgom
and removed request for
manosnoam
Robot Results
|
|
Has this been tested with 2.8 branch? |
|
No :( |
|
You know, the changes LGTM and shouldn't break anything hopefully. But I'm not even sure we truly need it for 2.8 - are the tests that this fixes actually present in this branch and are being run? I haven't checked personally, so asking 🙂 |
|
They are part of the smoke tests, so the goal here is to make at least the smoke tests as stable as possible and reduce the work related to failure investigations for 2.8.3, 2.8.4 , ... for several months |
|
In 2.8 we would need to add also other commits |
|
@apodhrad for 2.8, the smokes are basically always green in connected env. Do I understand correctly that you see these tests failing in disconnected? |
worse, these tests are green but they delete the ca bundles which could cause other failures, so it depends on the order of executed tests |
apodhrad
added
verified
|
@jstourac @mattmahoneyrh I have added changes related to restoring the ca bundles + the my recent change. |
Changes were manually picked up from these commits a132bb3 RHOAIENG-6358 Custom CA Bundle Save Restore Improvements 4094101 RHOAIENG-6358 Custom CA Bundle Save Restore Improvements c144a2a RHOAIENG-6358 Removed unneeded customCABundle default value restore 10fee65 RHOAIENG-6358 Fix lint warning f9ed258 RHOAIENG-6358 Documentation 033dc9e RHOAIENG-6358 Restore customCABundle Signed-off-by: Andrej Podhradsky <apodhrad@redhat.com>
Signed-off-by: Andrej Podhradsky <apodhrad@redhat.com>
|
apodhrad
merged commit 9c242ce
into
red-hat-data-services:releases/2.8.0
This was already merged to the master branch but we need it also for 2.8 smoke tests