-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connect/disconnect to/from google #2221
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie see testing instructions above. |
@blushi I'm getting this when I first log in with my email and navigate to the settings. These two things should be congruent (there should be a connect button not a disconnect button) https://monosnap.com/file/uvg5HJuextai7Wec0lSmHjI5uvTH9j |
@blushi I'm having trouble connecting with google Screen.Recording.2023-11-22.at.11.48.57.AM.mov |
It looks as if you were not logged in (only logged in users can connect an account to google, hence the unauthorized error: https://github.com/regen-network/regen-server/blob/fd79a95da729e64ef2e98d5340d89abc80fe376a/server/routes/auth.ts#L41). Could you describe how you logged in before trying to connect to google? which browser are you using? |
Looks like this might be a one-time issue based on the recent database migration for adding a specific google_email that can be different from the main email. This should not happen again. |
Nevermind, I could reproduce it using Brave so I'll investigate. |
@erikalogie @aaronc it looks like this is because Brave blocks inter-domain cookies by default (which is the case for deploy previews which have a different domain than the server, it should work fine on https://dev.app.regen.network/), even if they are set as |
This is working for me now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One minor comment.
Description
Closes: #2211
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Go to https://deploy-preview-2221--regen-marketplace.netlify.app/ and log in.
Go to the settings page and try connecting/disconnect to/from google.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...