Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nip-44 #88

Merged
merged 3 commits into from
Dec 25, 2024
Merged

nip-44 #88

merged 3 commits into from
Dec 25, 2024

Conversation

frnandu
Copy link
Collaborator

@frnandu frnandu commented Dec 25, 2024

fixes #87

@frnandu frnandu self-assigned this Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 84.28571% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.67%. Comparing base (141cc69) to head (bb39373).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
packages/ndk/lib/shared/nips/nip44/utils.dart 88.17% 11 Missing ⚠️
...ackages/ndk/lib/domain_layer/usecases/nwc/nwc.dart 0.00% 10 Missing ⚠️
packages/ndk/lib/shared/nips/nip44/nip44.dart 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   51.43%   52.67%   +1.23%     
==========================================
  Files         113      115       +2     
  Lines        3579     3719     +140     
==========================================
+ Hits         1841     1959     +118     
- Misses       1738     1760      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frnandu frnandu merged commit 693fdc8 into master Dec 25, 2024
3 checks passed
@frnandu frnandu deleted the nip-44 branch December 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nip44 notifications & responses
1 participant