Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nip-44 #88

Merged
merged 3 commits into from
Dec 25, 2024

Merge branch 'master' into nip-44

bb39373
Select commit
Loading
Failed to load commit list.
Merged

nip-44 #88

Merge branch 'master' into nip-44
bb39373
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 25, 2024 in 0s

52.67% (+1.23%) compared to 141cc69

View this Pull Request on Codecov

52.67% (+1.23%) compared to 141cc69

Details

Codecov Report

Attention: Patch coverage is 84.28571% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.67%. Comparing base (141cc69) to head (bb39373).

Files with missing lines Patch % Lines
packages/ndk/lib/shared/nips/nip44/utils.dart 88.17% 11 Missing ⚠️
...ackages/ndk/lib/domain_layer/usecases/nwc/nwc.dart 0.00% 10 Missing ⚠️
packages/ndk/lib/shared/nips/nip44/nip44.dart 97.29% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   51.43%   52.67%   +1.23%     
==========================================
  Files         113      115       +2     
  Lines        3579     3719     +140     
==========================================
+ Hits         1841     1959     +118     
- Misses       1738     1760      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov