Inherit stdio
in launch
+ make browsers
optional for update-browsers
#273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdio
inlaunch
, s.t. those who want to debug it can (elseRECORD_REPLAY_VERBOSE
is sent to Nirvana).stdio
seems to deadlock the browsers. I tried to debug by enabling it, but that just fixes it...unref
from the child process whenattach
is enabled, and instead wait for it to finish. This way, thereplay launch
process stays in sync with the lifecycle of the runtime, which allows any observer or caller to more easily wrap it.browsers
optional forupdate-browsers
, because that's what it was before and its easier to use for the average lazy person (like myself 👀)