Update Writing-A-Simple-Cpp-Service-And-Client.rst #3980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os2#3488) The original Fedora installation page was written back in the mists of time, and haven't changed a whole lot since then. However, the tooling to enable development of ROS 2 on Fedora *has* changed considerably (thanks in no small part to the efforts of @cottsay). In particular, developing on Fedora is 90% the same as developing on RHEL, with the only difference being that no additional repositories need to be enabled on Fedora. So merge together the Fedora and RHEL installation instructions. Note that we also redirect the old Fedora links to the RHEL installation page. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 87835ae) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
* Switch to ros2-testing for pre-release testing Signed-off-by: Yadunund <yadunund@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
… (ros2#3492) If the users follow the instructions as-is right now, they will fail to apt update before trying to install ros-dev-tools, which will lead to failure. Update the instructions here for that. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit f4b9ed2) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
) (ros2#3499) On arm64, rmw_connextdds doesn't exist so that one makes sense to skip. For amd64, it does exist but it doesn't matter if we skip the key; the binary archive is providing it. I'm not quite sure why iceoryx_binding_c doesn't work as a rosdep key, but like above it doesn't matter; the binary archive is providing it. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit c7db197) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
In particular, point to the page on docs.ros.org that shows how to use the bridge on Ubuntu Jammy. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 103a331) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
…#3500) (ros2#3510) That is, to temporarily skip packages it is probably a better idea for people to use --packages-skip, rather than doing a COLCON_IGNORE. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1b6f302) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
* Go directly to chocolately install page * Bump OpenSSL version Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: jmackay2 <1.732mackay@gmail.com>
* Update Using-Parameters-In-A-Class-Python.rst Updating to a more accurate description of the expected output (py). * Update Using-Parameters-In-A-Class-CPP.rst Updating to a more accurate description of the expected output (cpp). (cherry picked from commit 8a6ad2f) Co-authored-by: Mario Prats <marioprats@gmail.com>
That is, give a more realistic example of the package contents in Creating-Your-First-ROS2-Package. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit 1b680f2) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
* ros2pkg generates license warning messages. osrf/ros2_test_cases#954 * use `--license` option for the tutorial with ros2pkg command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit f29796f) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
) As far as I understand, docker-compose is the V1 version of the tool (which will stop being supported in June 2023). 'docker compose' is the V2 version of the tool, which is still supported. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 0f48507) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Distro A, OPSEC ros2#4584. You may have additional rights; please see https://rosmilitary.org/faq/?category=ros-2-license (cherry picked from commit d020a0e) Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com>
…#3906) The Prerequisites made it seem like this was a Linux only tutorial, when in reality it works on all of our platforms. Change this, and also do some light editing while we are in here. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 192070d) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
…3936) * Add UpstreamPackages to docs.ros.org documentation Copying from: http://wiki.ros.org/UpstreamPackages Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit b58ed0d) Co-authored-by: Tully Foote <tullyfoote@intrinsic.ai>
As a non-English native speaker, the lead part of the sentence was a bit hard to read. This commit simplifies it without (hoping) changing the meaning. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com> (cherry picked from commit f0c5507) Co-authored-by: Yasushi SHOJI <yasushi.shoji@gmail.com>
In particular, make it more clear which directory files should be downloaded into. Also clean up language just a bit and make sure we have one-sentence-per-line. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 6577908) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Changed the background section to clarify the roles (client and server) of the nodes communicating via a service Signed-off-by: Mustafa Alawadi <8343128+maalsolami@users.noreply.github.com>
fujitatomoya
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
this aligns with https://docs.ros.org/en/rolling/Concepts/Basic/About-Services.html
|
@maalsolami can you target the branch to |
|
Changed the base branch to |
|
@maalsolami this PR includes unrelated changes, can you rebase on rolling? |
|
There's been no response here in a long time, so I'm going to go ahead and close this. Please feel free to rebase and reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the background section to clarify the roles (client and server) of the nodes communicating via a service