-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Japanese translation #5272
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5272 +/- ##
==========================================
- Coverage 97.06% 94.26% -2.80%
==========================================
Files 451 451
Lines 9391 9450 +59
==========================================
- Hits 9115 8908 -207
- Misses 276 542 +266 ☔ View full report in Codecov by Sentry. |
Thank you for all these updates. Do you feel this is ready for review or are there more changes you would like to make? Should we have someone else check your work? My preference is for merging quickly and then applying fixes quickly but I would also appreciate a Japanese language review if possible. |
Sorry for the delay. Now it is ready for review (I made some changes to the draft.)
I agree with your approach of merging quickly and then applying fixes quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed.
config/locales/ja.yml
Outdated
pushによりこの名前を要求できます。<br/>もしあなたがこのgemの以前の所有者ならば、gem ownerコマンドを用いて所有者を変更できる他、新しいバージョンをgem | ||
pushを用いて公開できます。 | ||
pushによりこの名前を要求できます。<br/><br/>もしあなたがこのgemの以前の所有者ならば、gem ownerコマンドを用いてこのgemの所有者を変更したり、gem | ||
pushを用いて新しいバージョンを作成できます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
- gem pushを用いて新しいバージョンを作成できます。
+ gem pushコマンドを用いて新しいバージョンを作成できます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in bd9bed7
config/locales/ja.yml
Outdated
@@ -590,8 +601,8 @@ ja: | |||
create: | |||
success_notice: "%{handle}が未確定の所有者として追加されました。当該ユーザーがEメールに送られた確定メールでクリックした後に所有権アクセスが有効になります。" | |||
update: | |||
update_current_user_role: | |||
success_notice: | |||
update_current_user_role: 自分のロールは更新できません |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original text contains the word "own".
How about this?
- 自分のロールは更新できません
+ 自分自身のロールは更新できません
``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in bbab305
config/locales/ja.yml
Outdated
recovery: | ||
continue: 続ける | ||
title: 復旧コード | ||
saved: 復旧コードを保存したことを確認しました。 | ||
confirm_dialog: | ||
confirm_dialog: 復旧コードをコピーしなくてよろしいですか? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
- 復旧コードをコピーしなくてよろしいですか?
+ 復旧コードをコピーせずに離れますか?
or
+ 復旧コードをコピーせずにこのページを離れますか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in 68a1add
config/locales/ja.yml
Outdated
gems: gem | ||
history: 履歴 | ||
members: メンバー | ||
no_history: まだ何もありません |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
- まだ何もありません
+ まだ履歴がありません
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in 256c14c
config/locales/ja.yml
Outdated
@@ -108,14 +108,14 @@ ja: | |||
ownership_request: | |||
attributes: | |||
user_id: | |||
taken: | |||
existing: | |||
taken: 所有権は申請済みです |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original text contains the word "already".
How about this?
- 所有権は申請済みです
+ 所有権は既に申請済みです
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message was removed in b093b95
config/locales/ja.yml
Outdated
@@ -99,7 +99,7 @@ ja: | |||
organization: | |||
attributes: | |||
handle: | |||
invalid: | |||
invalid: は英字から始まり、英字、数字、下線文字、ダッシュのみが含まれていなければなりません |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
- は英字から始まり、英字、数字、下線文字、ダッシュのみが含まれていなければなりません
+ は英字から始まり、英字、数字、アンダーバー、ハイフンのみが含まれていなければなりません
Although not a literal translation of the original, _
is often referred to as an underbar
and -
as a hyphen
in japanese.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mfa_required_not_yet_enabled: | | ||
[エラー]アカウントとgemの保護のため、 https://rubygems.org/totp/new で多要素認証の設定が必要です。 | ||
|
||
詳しくはブログ記事をお読みください (https://blog.rubygems.org/2022/08/15/requiring-mfa-on-popular-gems.html)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to use ()
instead of ()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll use ()
. Some browsers might have a URL detection feature, and using a full width character might cause problems.
config/locales/ja.yml
Outdated
|
||
詳しくはブログ記事をお読みください (https://blog.rubygems.org/2022/08/15/requiring-mfa-on-popular-gems.html)。 | ||
mfa_required_weak_level_enabled: | | ||
[エラー]アカウントのgemの保護のため、 https://rubygems.org/settings/edit でMFAの水準を「UIとgemのサインイン」または「UIとAPI」に変える必要があります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo.
- アカウントのgemの保護のため
+ アカウントとgemの保護のため
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in 82399bb
config/locales/ja.yml
Outdated
@@ -21,11 +21,11 @@ ja: | |||
locale_name: 日本語 | |||
none: なし | |||
not_found: 見つかりませんでした | |||
forbidden: | |||
api_gem_not_found: | |||
forbidden: 認可が拒否されました |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
- 認可が拒否されました
+ 禁止されています
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in 05dbb31
Co-authored-by: @w-masahiro-ct <watanabe@cadenza-tech.com>
Co-authored-by: @w-masahiro-ct <watanabe@cadenza-tech.com>
Co-authored-by: @w-masahiro-ct <watanabe@cadenza-tech.com>
Co-authored-by: @w-masahiro-ct <watanabe@cadenza-tech.com>
Co-authored-by: @w-masahiro-ct <watanabe@cadenza-tech.com>
Co-authored-by: @w-masahiro-ct <watanabe@cadenza-tech.com>
Co-authored-by: @w-masahiro-ct <watanabe@cadenza-tech.com>
Co-authored-by: @w-masahiro-ct <watanabe@cadenza-tech.com>
@w-masahiro-ct Thank you for your review. I applied/replied-to your suggestions. I've added an additional commit 80eb3d8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this now that we have a review of the translations. Thank you for all your help.
Hello RubyGems,
This updates Japanese translation (continuation of #4779).
Each commit adds changes corresponding to those made to the respective English/Japanese file (
en.yml
/ja.yml
), as specified in the commit subject.Thank you,
gemmaro.
TODOs to be ready for review.