Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve home heading for japanese #5391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

w-masahiro-ct
Copy link
Contributor

Before After
スクリーンショット 2025-01-14 午前0 58 00 スクリーンショット 2025-01-14 午前0 58 31

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (f812bb4) to head (2d843a4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5391      +/-   ##
==========================================
- Coverage   97.06%   94.25%   -2.81%     
==========================================
  Files         451      451              
  Lines        9391     9450      +59     
==========================================
- Hits         9115     8907     -208     
- Misses        276      543     +267     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi simi requested a review from hsbt January 13, 2025 16:42
@martinemde
Copy link
Member

Hi! Thanks for the contribution.

Would you be willing to cross-check #5272 and maybe we can get both merged?

@w-masahiro-ct
Copy link
Contributor Author

I have reviewed #5272👌

@martinemde
Copy link
Member

Thanks for your help on #5272, @w-masahiro-ct. I was worried about conflicts with that PR and wanted to get it in first.

If we rebase, we can probably merge this one too. There's not as many Japanese language changes, but maybe @gemmaro could take a look too if they have a moment?

@w-masahiro-ct w-masahiro-ct force-pushed the improve-home-heading-for-japanese branch from 35a614c to 2d843a4 Compare January 18, 2025 15:07
@w-masahiro-ct
Copy link
Contributor Author

I have just rebased now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants