Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reducing warnings #3387

Merged
merged 3 commits into from
Jan 25, 2025
Merged

chore: reducing warnings #3387

merged 3 commits into from
Jan 25, 2025

Conversation

henryiii
Copy link
Member

Reducing a few more warnings:

  • Updated rapidjson to the latest commit, which removes all the "deprecated in C++17" warnings. There hasn't been a release of rapidjson in many, many years.
  • Dropped a useless variable. If it was supposed to be used, then that should probably be fixed instead.
  • Made it possible to compile directly, without scikit-build-core. Makes it easier to run clang-tidy, for example.

There are a bunch of signed -> unsigned conversions happening in one file which I did not fix yet.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryiii - looks good to me. Thanks!

@ianna ianna merged commit bde47c1 into main Jan 25, 2025
40 checks passed
@ianna ianna deleted the henryiii/chore/moresmallcleanup branch January 25, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants