Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reducing warnings #3387

Merged
merged 3 commits into from
Jan 25, 2025
Merged

chore: reducing warnings #3387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74686f3
chore: reducing warnings
henryiii Jan 24, 2025
e99b1db
Merge branch 'main' into henryiii/chore/moresmallcleanup
ianna Jan 24, 2025
5511ee8
Merge branch 'main' into henryiii/chore/moresmallcleanup
ianna Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions awkward-cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

cmake_minimum_required(VERSION 3.15...3.30)

if(NOT DEFINED SKBUILD)
set(SKBUILD_PROJECT_NAME awkward_cpp)
set(SKBUILD_PROJECT_VERSION 0.0.0)
endif()

# Project must be near the top
project(
${SKBUILD_PROJECT_NAME}
Expand Down
2 changes: 1 addition & 1 deletion awkward-cpp/rapidjson
Open in desktop
Submodule rapidjson updated 150 files
2 changes: 0 additions & 2 deletions awkward-cpp/src/libawkward/forth/ForthMachine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,13 +1684,11 @@ namespace awkward {
throw std::invalid_argument(
std::string("unclosed string after .\" or s\" word") + FILENAME(__LINE__));
}
int64_t nextline = line;
current = source_[stop];
start = stop;
colstart = colstop;
while (current != '\"' || source_[stop - 1] == '\\') {
if (current == '\n') {
nextline++;
colstart = 0;
colstop = 0;
}
Expand Down
Loading