Swift Package Manager support #34
Conversation
Make EventManagerConfig public init
Podfile
Outdated
| @@ -1,5 +1,6 @@ | |||
| platform :ios, '12.0' | |||
There was a problem hiding this comment.
@mroloux @bverbeken looks like README.md is out of date, it says we support minimum version iOS 9.0 and newer
There was a problem hiding this comment.
@schaloner I have updated README.md
Podfile.lock
Outdated
| @@ -1,3 +1,16 @@ | |||
| PODFILE CHECKSUM: 7e3d3d38e3c6c64c581bdfbe83e25e0034c3de26 | |||
| PODS: | |||
There was a problem hiding this comment.
I'm far from an expert, but why does Prodfile.lock need a reference to v17 of its own project?
There was a problem hiding this comment.
For the future, it would be good to have separate targets for the app (example) and library (seatsio) and use the library in the app for testing.
I'm using the development pod here to see how the pod will be generated as we use the same target for the library and example app.
https://guides.cocoapods.org/making/development-cocoapods.html
I'll set up multiple targets as soon as I have a bit of free time!
There was a problem hiding this comment.
@mroloux , I've separated the example app and framework. Could you please review it once more? Also, could you set up the actions to skip running the pod install?
There was a problem hiding this comment.
Maybe it's better if you remove pod install in this branch? Then we see if the build succeeds.
It's in build.yml and release.yml.
| @@ -1,5 +0,0 @@ | |||
| platform :ios, '12.0' | |||
|
|
|||
| target 'seatsio-ios' do | |||
There was a problem hiding this comment.
Podfile is not needed anymore.
Changes
Testing