-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Package Manager support #34
Changes from 11 commits
e7937dd
254cc4f
a10e9df
611ebe5
e4135c4
128649a
fba2333
eb90ce9
78b32b9
efe2932
3a9e3dc
c0ada52
dcf38a7
b5e0c14
27efd3c
9f148dc
50b5663
840bc1c
f91197b
cfa082c
4d808f8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// swift-tools-version: 5.7 | ||
// The swift-tools-version declares the minimum version of Swift required to build this package. | ||
|
||
import PackageDescription | ||
|
||
let package = Package( | ||
name: "seatsio-ios", | ||
platforms: [.iOS(.v12)], | ||
products: [ | ||
.library( | ||
name: "Seatsio", | ||
targets: ["Seatsio"]), | ||
], | ||
targets: [ | ||
.target(name: "Seatsio"), | ||
] | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
platform :ios, '12.0' | ||
|
||
target 'seatsio-ios' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Podfile is not needed anymore. |
||
target 'Seatsio' do | ||
use_frameworks! | ||
pod 'seatsio', :path => 'seatsio.podspec' | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,16 @@ | ||
PODFILE CHECKSUM: 7e3d3d38e3c6c64c581bdfbe83e25e0034c3de26 | ||
PODS: | ||
- seatsio (17.0.0) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm far from an expert, but why does There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the future, it would be good to have separate targets for the app (example) and library (seatsio) and use the library in the app for testing. I'm using the development pod here to see how the pod will be generated as we use the same target for the library and example app. I'll set up multiple targets as soon as I have a bit of free time! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mroloux , I've separated the example app and framework. Could you please review it once more? Also, could you set up the actions to skip running the pod install? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it's better if you remove It's in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
||
DEPENDENCIES: | ||
- seatsio (from `seatsio.podspec`) | ||
|
||
EXTERNAL SOURCES: | ||
seatsio: | ||
:path: seatsio.podspec | ||
|
||
SPEC CHECKSUMS: | ||
seatsio: 7d058764f6e902acf9ac2cff57adc01d258d04cd | ||
|
||
PODFILE CHECKSUM: 8788e1d003b00db38f11e4fb362978f48684c865 | ||
|
||
COCOAPODS: 1.15.2 |
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mroloux @bverbeken looks like
README.md
is out of date, it says we support minimum version iOS 9.0 and newerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schaloner I have updated
README.md