[c++] Integrate SOMAColumn: Update domain accessors inside SOMAArray, part 2
#3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XanthosXanthopoulos
changed the title
SOMAColumn to access domain inside SOMAArray Part 3SOMAColumn to access domain inside SOMAArray Part 3 [WIP]
johnkerl
changed the title
SOMAColumn to access domain inside SOMAArray Part 3 [WIP]SOMAColumn to access domain inside SOMAArray part 3 [WIP]
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-column-somarray-integration
branch
from
cbe3cf0 to
29448a2
Compare
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-column-arrow-integration
branch
from
b1bd03c to
5485141
Compare
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-column-somarray-integration
branch
from
29448a2 to
d4e4d7e
Compare
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-column-arrow-integration
branch
2 times, most recently
from
0e69ed7 to
d6d6187
Compare
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-column-somarray-integration
branch
from
d4e4d7e to
e746f3b
Compare
XanthosXanthopoulos
changed the title
SOMAColumn to access domain inside SOMAArray part 3 [WIP]SOMAColumn: Update domain accessors inside SOMAArray, part 2
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-column-arrow-integration
branch
3 times, most recently
from
2401416 to
77a01e1
Compare
… update python bindings
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-column-somarray-integration
branch
from
e746f3b to
9ce6608
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
SOMAArrayobject construction and open theSOMAColumnobjects are initialized and used througout the lifetime of theSOMAArrayobject to access the different domain types for the object. The complexity of transforming the data to an ArrowTable has been transferred to eachSOMAColumnand that makesSOMAArrayimplementation agnostic of any column specific restrictions.