#2 Add integration test #4
Conversation
…service in circleci config file
.circleci/config.yml
Outdated
| git clone https://github.com/singnet/platform-contracts.git | ||
| cd platform-contracts | ||
| npm install | ||
| npm install ganache-cli |
There was a problem hiding this comment.
Actually commands above doesn't build platform-contracts they just clone repository and install dependencies. To build contracts you should run: npm run-script compile and npm run-script package-npm.
.circleci/config.yml
Outdated
| cd $SINGNET_REPOS | ||
| git clone https://github.com/singnet/snet-cli.git | ||
| cd snet-cli | ||
| ./scripts/blockchain install |
There was a problem hiding this comment.
I think we need to copy contracts from token-contracts and platform-contracts instead.
npm install <folder> command can be used to do this.
.circleci/config.yml
Outdated
| # Install other | ||
| sudo apt-get -y install libudev-dev libusb-1.0-0-dev | ||
| - run: | ||
| name: Build platform-contracts |
There was a problem hiding this comment.
It is worth to add token-contracts as well.
.circleci/config.yml
Outdated
| cd $SINGNET_REPOS | ||
| git clone https://github.com/singnet/snet-daemon.git | ||
| cd snet-daemon | ||
| ./scripts/install |
There was a problem hiding this comment.
Same thing regarding contracts as for snet-cli.
There was a problem hiding this comment.
I update the circleci config to build projects using downloaded parents.
| return err | ||
| } | ||
|
|
||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
Why it is needed? Usually you cannot rely on such delays.
There was a problem hiding this comment.
Removing the delay requires adding some logging to the snet-daemon and example service that they are ready. I would prefer to make it as a separate fix.
utils.go
Outdated
| return cmd, nil | ||
| } | ||
|
|
||
| func check_with_timeout(f check_with_timeout_type) (bool, error) { |
There was a problem hiding this comment.
I would add timeout to the function parameters.
There was a problem hiding this comment.
The timeout and tick arguments are added to the checkWithTimeout func.
utils.go
Outdated
| return err | ||
| } | ||
|
|
||
| func link_file(file_from string, file_to string) error { |
There was a problem hiding this comment.
Update to use os.Symlink instead of running ln from a command line.
No description provided.