fix: code review fixes

sitepark · Jan 16, 2024 · f11d288 · f11d288
1 parent d7c8ffd
commit f11d288
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 0 deletions.
diff --git a/test/DataBagTest.php b/test/DataBagTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Atoolo\Resource\Test;
 
 use Atoolo\Resource\DataBag;
@@ -62,6 +64,18 @@ public function testGetStringWithDefault(): void
         );
     }
 
+    public function testGetDifferentType(): void
+    {
+        $resource = new DataBag(
+            ['field' => '123']
+        );
+        $this->assertEquals(
+            0,
+            $resource->getInt('field'),
+            'expected value to be fallback of zero'
+        );
+    }
+
     public function testGetInt(): void
     {
         $resource = new DataBag(

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/a.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/a.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/a.php',
     'a',

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/b.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/b.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/b.php',
     'b',

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/c.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/c.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/c.php',
     'c',

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/childrenWithInvalidData.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/childrenWithInvalidData.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/primaryParentWithoutUrl.php',
     'primaryParentWithoutUrl',

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/firstParentWithNonStringUrl.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/firstParentWithNonStringUrl.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/primaryParentWithoutUrl.php',
     'primaryParentWithoutUrl',

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/firstParentWithoutUrl.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/firstParentWithoutUrl.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/primaryParentWithoutUrl.php',
     'primaryParentWithoutUrl',

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/primaryParentWithInvalidData.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/primaryParentWithInvalidData.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/primaryParentWithoutUrl.php',
     'primaryParentWithoutUrl',

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/primaryParentWithNonStringUrl.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/primaryParentWithNonStringUrl.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/primaryParentWithoutUrl.php',
     'primaryParentWithoutUrl',

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/primaryParentWithoutUrl.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/primaryParentWithoutUrl.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return new \Atoolo\Resource\Resource(
     '/primaryParentWithoutUrl.php',
     'primaryParentWithoutUrl',