-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Gap] A VLAN interface should stay up when all of its member ports are operationally down #15244
[Test Gap] A VLAN interface should stay up when all of its member ports are operationally down #15244
Conversation
…of its member ports are operationally down. Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
/azp run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
…st_vlan_ports_down.py now restores the previous state of ports instead of starting up all of them. Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
/azp run Azure.sonic-mgmt |
Commenter does not have sufficient privileges for PR 15244 in repo sonic-net/sonic-mgmt |
…e logging statements to the test. Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of PR
Summary:
Fixes #14790
When all member ports of a VLAN are down, the VLAN interface should still remain operationally up. The added test file (
test_vlan_ports_down.py
) performs the following steps:Setup: Brings down all member ports of a VLAN interface.
Tear-down: Starts up all member ports of the VLAN interface.
Type of change
Back port request
Approach
What is the motivation for this PR?
When all member ports of a VLAN are down, the VLAN interface should still remain operationally up.
How did you do it?
We select a VLAN and then bring all of its member ports down. Then we assert all 3 conditions mentioned in the summary.
How did you verify/test it?
Ran the test on a virtual T0 switch (with Broadcom ASIC).
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
T0