-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frame visualization to Meshcat visualizer #2098
Conversation
Hi ! This project doesn't usually accept pull requests on the main branch. |
fab200e
to
1186f62
Compare
bde96a1
to
db5233c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for adding this useful feature !
I guess we could add parameters in loadViewerModel
to let the user define if they want to display collisions, visuals, and/or frames or not, but this is out of the scope of this PR, and would better be consistently applied on all viewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sea-bass for this very helpful contribution.
## [2.6.21] - 2023-11-27 ### Added - Add inverse dynamics (`rnea`) Python and C++ example ([2083](stack-of-tasks/pinocchio#2083)) - Add visualization of Frames in MeshCat viewer ([2098](stack-of-tasks/pinocchio#2098)) ### Fixed - Re-initialize `Ycrb[0]` in `crbaMinimal` ([2040](stack-of-tasks/pinocchio#2040)) - Fix custom scalar use in `log` function ([2047](stack-of-tasks/pinocchio#2047)) - Raise exception on wrong input size in `XYZQUATToSE3` Python binding function ([2073](stack-of-tasks/pinocchio#2073)) - Remove memory leak in `buildGeomFromUrdf` and `buildGeomFromUrdfString` Python binding functions ([2082]()stack-of-tasks/pinocchio#2082) - Fix Panda3D viewer examples ([2087](stack-of-tasks/pinocchio#2087)) - Fix centroidal dynamics derivatives with respect to time ([2094](stack-of-tasks/pinocchio#2094))) ### Changed - Rename freeflyer_joint to root_joint in `humanoid` sample model ([2043](stack-of-tasks/pinocchio#2043)) - CMake minimal version is now 3.10 ([2055](stack-of-tasks/pinocchio#2055)) - Split headers and sources in different directories to have a more standard C++ project ([2070](stack-of-tasks/pinocchio#2070)) ### Removed - Remove support to `hpp-fcl` < v2.0.0 ([2086](stack-of-tasks/pinocchio#2086)) ## Packaging changes - removed patches ad, ae: fixed upstream 🎉 - updated patches af, ah, an - added patch ao
This PR adds frame visualization to the Meshcat visualizer -- the use case here is for some educational content I'm making where I will start with a pure model that has no visual or collision models, and I still want the frames to show up. But I also think it would generally be useful to have this available.
Frame visualization is
False
by default to not change behavior for users.The repro case for the animation below looks roughly like this right now:
2023-11-25.12-29-47.mp4