Mjcf: Use xyz as a default value for eulerseq compiler option #2526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initializes
mapEulerAngles
with an identity matrix by default (matching MuJoCo's default 'xyz' sequence as documented in https://mujoco.readthedocs.io/en/stable/XMLreference.html#compiler-eulerseq).While testing robots from https://github.com/google-deepmind/mujoco_menagerie, I encountered nan values in some frame transforms. After debugging, I found out that
mapEulerAngles
was not initialized by default and returned garbage values when no eulerseq was specified.