Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mjcf: Use xyz as a default value for eulerseq compiler option #2526

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

JafarAbdi
Copy link

This PR initializes mapEulerAngles with an identity matrix by default (matching MuJoCo's default 'xyz' sequence as documented in https://mujoco.readthedocs.io/en/stable/XMLreference.html#compiler-eulerseq).

While testing robots from https://github.com/google-deepmind/mujoco_menagerie, I encountered nan values in some frame transforms. After debugging, I found out that mapEulerAngles was not initialized by default and returned garbage values when no eulerseq was specified.

@hrp2-14
Copy link

hrp2-14 commented Dec 22, 2024

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@JafarAbdi JafarAbdi changed the base branch from master to devel December 22, 2024 16:19
@JafarAbdi JafarAbdi force-pushed the fix_default_eulerseq branch from 8758e96 to 175f991 Compare December 22, 2024 16:21
jcarpent
jcarpent previously approved these changes Dec 22, 2024
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @JafarAbdi for this nice contribution. Thanks a lot for adding the test.

@jcarpent jcarpent merged commit c0d86b5 into stack-of-tasks:devel Dec 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants