chore(wallet)_: community deployment related types moved to wallet requests package #6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
saledjenic
requested review from
a team,
iurimatias,
osmaczko,
Cuteivist,
Khushboo-dev-cpp,
alaibe and
jrainville
and removed request for
a team
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-1
branch
from
1d65c1d to
dd8d64c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6261 +/- ##
========================================
Coverage 61.56% 61.56%
========================================
Files 845 846 +1
Lines 110696 110698 +2
========================================
+ Hits 68147 68155 +8
+ Misses 34585 34578 -7
- Partials 7964 7965 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
approved these changes
Jan 20, 2025
…quests package `DeploymentParameters` and `DeploymentDetails` types moved from `communitytokens` package to `requests` of the wallet service.
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-1
branch
from
dd8d64c to
bd9e28c
Compare
dlipicar
reviewed
Jan 23, 2025
|
|
||
| var ( | ||
| ErrEmptyCollectibleName = &errors.ErrorResponse{Code: errors.ErrorCode("WRRC-001"), Details: "empty collectible name"} | ||
| ErrEmptyCollectibleSymbol = &errors.ErrorResponse{Code: errors.ErrorCode("WRRC-002"), Details: "empty collectible symbol"} |
There was a problem hiding this comment.
Do these endpoints only apply to Collectibles? I though they were used for assets as well (since there's a Decimals member in the struct)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeploymentParametersandDeploymentDetailstypes moved fromcommunitytokenspackage torequestsof the wallet service.This is the first step in moving community-related transactions from
communitytokenstowalletservice.Related PRs: