Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(communities)!: rename communitytokensv2 package to communitytokens #6263

Open
wants to merge 2 commits into
base: move-community-minting-airdrop-to-router
Choose a base branch
from

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Jan 16, 2025

This is a breaking change which renames communitytokensv2 package to communitytokens.

This is the last PR in moving community-related transactions from communitytokens to wallet service.
Related PRs:

Copy link

github-actions bot commented Jan 16, 2025

Looks like you have BREAKING CHANGES in your PR.
Please make sure to follow 💔How to introduce breaking changes guide:

Check-list

@status-im-auto
Copy link
Member

status-im-auto commented Jan 16, 2025

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7de1b0b #1 2025-01-16 18:36:38 ~4 min macos 📦zip
✔️ 7de1b0b #1 2025-01-16 18:36:48 ~4 min linux 📦zip
✔️ 7de1b0b #1 2025-01-16 18:37:04 ~4 min ios 📦zip
✔️ 7de1b0b #1 2025-01-16 18:37:32 ~5 min macos 📦zip
✔️ 7de1b0b #1 2025-01-16 18:37:49 ~5 min windows 📦zip
✔️ 7de1b0b #1 2025-01-16 18:38:17 ~6 min android 📦aar
✖️ 7de1b0b #1 2025-01-16 18:39:04 ~6 min tests-rpc 📄log
✔️ 7de1b0b #1 2025-01-16 19:03:18 ~31 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a9a333d #2 2025-01-17 11:32:14 ~3 min macos 📦zip
✔️ a9a333d #2 2025-01-17 11:33:01 ~4 min ios 📦zip
✔️ a9a333d #2 2025-01-17 11:33:08 ~4 min windows 📦zip
✔️ a9a333d #2 2025-01-17 11:33:30 ~4 min linux 📦zip
✔️ a9a333d #2 2025-01-17 11:34:14 ~5 min macos 📦zip
✔️ a9a333d #2 2025-01-17 11:34:50 ~6 min android 📦aar
✖️ a9a333d #2 2025-01-17 11:35:03 ~6 min tests-rpc 📄log
✔️ a9a333d #2 2025-01-17 11:59:55 ~31 min tests 📄log
✔️ 26ff226 #3 2025-01-23 18:32:34 ~10 min ios 📦zip
✔️ 26ff226 #3 2025-01-23 18:59:43 ~6 min android 📦aar
✔️ 26ff226 #3 2025-01-23 21:33:36 ~31 min tests 📄log
✖️ 26ff226 #3 2025-01-23 23:20:54 ~6 min tests-rpc 📄log
✔️ 26ff226 #3 2025-01-24 10:48:24 ~5 min linux 📦zip
✔️ 26ff226 #3 2025-01-24 11:20:27 ~4 min macos 📦zip
✔️ 26ff226 #3 2025-01-24 11:26:15 ~7 min macos 📦zip
✔️ 26ff226 #3 2025-01-24 13:05:00 ~6 min windows 📦zip

@saledjenic saledjenic requested review from alaibe, jrainville, igor-sirotin, a team and Khushboo-dev-cpp and removed request for a team January 16, 2025 18:48
@saledjenic saledjenic marked this pull request as ready for review January 16, 2025 18:48
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 29.78723% with 66 lines in your changes missing coverage. Please review.

Project coverage is 61.84%. Comparing base (d442b09) to head (26ff226).

Files with missing lines Patch % Lines
services/communitytokens/service.go 21.42% 43 Missing and 1 partial ⚠️
services/communitytokens/api.go 0.00% 18 Missing ⚠️
services/communitytokens/manager.go 78.57% 3 Missing ⚠️
api/geth_backend.go 75.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (29.78%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                             Coverage Diff                              @@
##           move-community-minting-airdrop-to-router    #6263      +/-   ##
============================================================================
+ Coverage                                     61.27%   61.84%   +0.56%     
============================================================================
  Files                                           856      849       -7     
  Lines                                        112644   111405    -1239     
============================================================================
- Hits                                          69027    68902     -125     
+ Misses                                        35648    34536    -1112     
+ Partials                                       7969     7967       -2     
Flag Coverage Δ
functional 21.66% <29.78%> (+0.07%) ⬆️
unit 60.33% <10.63%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
node/get_status_node.go 51.46% <ø> (ø)
node/status_node_services.go 71.19% <100.00%> (-0.34%) ⬇️
protocol/communities/manager.go 66.22% <ø> (-0.17%) ⬇️
services/ext/service.go 28.19% <100.00%> (ø)
api/geth_backend.go 54.32% <75.00%> (+0.05%) ⬆️
services/communitytokens/manager.go 57.14% <78.57%> (+9.14%) ⬆️
services/communitytokens/api.go 4.54% <0.00%> (+3.53%) ⬆️
services/communitytokens/service.go 17.57% <21.42%> (+3.48%) ⬆️

... and 31 files with indirect coverage changes

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I wonder if you just merged this in the other branch if it wouldn't make reviewing less painful. Having to review file copy paste is very hard

@saledjenic saledjenic force-pushed the move-community-minting-airdrop-to-router branch from 6dcc4bd to d442b09 Compare January 23, 2025 14:41
This is a breaking change which removes `communitytokens` package.

This commit removes old `communitytokens` package, cause previously added `communitytokensv2` package,
which is in use now, will be renamed to `communitytokens` in next commit.
This is a breaking change which renames `communitytokensv2` package to `communitytokens`.
@saledjenic saledjenic force-pushed the move-community-minting-airdrop-to-router-post-step-1 branch from a9a333d to 26ff226 Compare January 23, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants