-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(communities)!: rename communitytokensv2 package to communitytokens #6263
base: move-community-minting-airdrop-to-router
Are you sure you want to change the base?
chore(communities)!: rename communitytokensv2 package to communitytokens #6263
Conversation
Looks like you have BREAKING CHANGES in your PR. Check-list
|
Jenkins BuildsClick to see older builds (8)
|
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (29.78%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## move-community-minting-airdrop-to-router #6263 +/- ##
============================================================================
+ Coverage 61.27% 61.84% +0.56%
============================================================================
Files 856 849 -7
Lines 112644 111405 -1239
============================================================================
- Hits 69027 68902 -125
+ Misses 35648 34536 -1112
+ Partials 7969 7967 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
87cf27f
to
3394343
Compare
7de1b0b
to
a9a333d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wonder if you just merged this in the other branch if it wouldn't make reviewing less painful. Having to review file copy paste is very hard
6dcc4bd
to
d442b09
Compare
This is a breaking change which removes `communitytokens` package. This commit removes old `communitytokens` package, cause previously added `communitytokensv2` package, which is in use now, will be renamed to `communitytokens` in next commit.
This is a breaking change which renames `communitytokensv2` package to `communitytokens`.
a9a333d
to
26ff226
Compare
This is a breaking change which renames
communitytokensv2
package tocommunitytokens
.This is the last PR in moving community-related transactions from
communitytokens
towallet
service.Related PRs: