Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Cookbook Cleanup #480

Merged
merged 1 commit into from
May 13, 2014
Merged

Cookbook Cleanup #480

merged 1 commit into from
May 13, 2014

Conversation

dbu
Copy link
Member

@dbu dbu commented May 9, 2014

Cleaning up cookbook and killing some redundant articles

Q A
Doc fix? yes
New docs? yes
Applies to 1.1+ of the doc
Fixed tickets #283 #257

I am not really adressing #49 - should we move the installation guides elsewhere? i think its not to bad now, with a cookbook section on installations.

what is now even more obviously missing is the editing book section #239.

@@ -1,44 +1,55 @@
.. index::
single: Multi Language Documents
single: Multi Language; Getting Started
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still more in a tutorial style than a book chapter style. Do we have to split this and have a terse tutorial in cookbook and a nice verbose introduction in the book? I am afraid of that, as its duplicating information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting Started -> Book

@wouterj
Copy link
Member

wouterj commented May 9, 2014

Wow, this is great! :) I'll look at it this weekend.

Thanks for putting such a lot of time into the docs. It's a shame I haven't done much the last months...

@dbu
Copy link
Member Author

dbu commented May 9, 2014

you are doing quite some work, and you reviewing and keeping things consistent is much appreciated!


Lunetics LocaleBundle
---------------------
You also need the ``intl`` php extension installed and enabled. (Otherwise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] and enabled (otherwise [...]

.. _`Installation of Symfony2`: http://symfony.com/doc/2.1/book/installation.html
cmf_core:
persistence:
phpcr:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcr: true ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, if we keep the enabled, its easier for people to add some more configuration. if you are convinced its better to say phpcr: true (or phpcr: ~) i can change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsmith77 lsmith77 added this to the 1.1 milestone May 12, 2014
@dbu
Copy link
Member Author

dbu commented May 12, 2014

cleaned up and solved merge conflicts. need to decide on how we enable phpcr, then should be good to merge.

lsmith77 added a commit that referenced this pull request May 13, 2014
note that multi lang will be handled in a dedicated chapter, see #480
@wouterj
Copy link
Member

wouterj commented May 13, 2014

Rebased, let's wait one more time on Travis and merge it.

wouterj added a commit that referenced this pull request May 13, 2014
@wouterj wouterj merged commit a4598a0 into dev May 13, 2014
@wouterj wouterj deleted the cookbook-sonata branch May 13, 2014 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants