add recipe for liip/theme-bundle:1.5.* #209
Conversation
lsmith77
commented
Dec 17, 2017
lsmith77
commented
| Q | A |
|---|---|
| License | MIT |
ghost
deployed
to
|
now can I ensure that |
lsmith77
force-pushed
the
liip-theme-bundle
branch
from
cecd53b to
e768423
Compare
| @@ -0,0 +1,3 @@ | |||
| framework: | |||
| templating: | |||
| engines: ['twig'] | |||
There was a problem hiding this comment.
ok .. that doesn’t seem to do the trick :-/
There was a problem hiding this comment.
would it work if I fold it into the theme.yaml?
There was a problem hiding this comment.
Using the Symfony Templating layer as done here is "forbidden" in Symfony 3.4/4.0. Supporting Twig directly is what is epxected in recipes.
There was a problem hiding this comment.
ok .. which requires a major refactoring of this Bundle .. which I am currently not planning to work on (see liip/LiipThemeBundle#181).
so I guess I will close this PR
| <options=bold>Configure</> the bundle and routes: | ||
| 1. You <options=bold>MUST</> verify the configuration in <comment>%CONFIG_DIR%/packages/theme.yaml</>. | ||
| 2. You <options=bold>MAY</> configure additional features, see the README.md for instructions. | ||
| 3. You <options=bold>MAY</> configure the routes as specified in the README.md if you enable the controller. |
There was a problem hiding this comment.
You should remove the post-install
| @@ -0,0 +1,3 @@ | |||
| framework: | |||
| templating: | |||
| engines: ['twig'] | |||
There was a problem hiding this comment.
Using the Symfony Templating layer as done here is "forbidden" in Symfony 3.4/4.0. Supporting Twig directly is what is epxected in recipes.
