Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for liip/theme-bundle:1.5.* #209

Closed
wants to merge 1 commit into from
Closed

add recipe for liip/theme-bundle:1.5.* #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions liip/theme-bundle/1.5/config/packages/framework.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
framework:
templating:
engines: ['twig']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok .. that doesn’t seem to do the trick :-/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it work if I fold it into the theme.yaml?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the Symfony Templating layer as done here is "forbidden" in Symfony 3.4/4.0. Supporting Twig directly is what is epxected in recipes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok .. which requires a major refactoring of this Bundle .. which I am currently not planning to work on (see liip/LiipThemeBundle#181).

so I guess I will close this PR

4 changes: 4 additions & 0 deletions liip/theme-bundle/1.5/config/packages/theme.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
liip_theme:
themes: ['default']
active_theme: 'default'
load_controllers: false
8 changes: 8 additions & 0 deletions liip/theme-bundle/1.5/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"bundles": {
"Liip\\ThemeBundle\\LiipThemeBundle": ["all"]
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
}
}
6 changes: 6 additions & 0 deletions liip/theme-bundle/1.5/post-install.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<bg=blue;fg=white> Getting started using </><bg=blue;fg=white;options=bold>liip/theme-bundle</><bg=blue;fg=white> </>

<options=bold>Configure</> the bundle and routes:
1. You <options=bold>MUST</> verify the configuration in <comment>%CONFIG_DIR%/packages/theme.yaml</>.
2. You <options=bold>MAY</> configure additional features, see the README.md for instructions.
3. You <options=bold>MAY</> configure the routes as specified in the README.md if you enable the controller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove the post-install