Update order modifier queries #3479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes interpolation easier
dpanta94
reviewed
Jan 10, 2025
dpanta94
reviewed
Jan 10, 2025
| * @test | ||
| * @return void | ||
| */ | ||
| public function should_find_all_fees() { |
There was a problem hiding this comment.
Are we sure that the most crucial functionality introduced is covered by this test case ? If not, could we become please ?
Camwyn
requested changes
Jan 10, 2025
src/Tickets/Commerce/Order_Modifiers/Modifiers/Modifier_Abstract.php
Outdated
Show resolved
Hide resolved
src/Tickets/Commerce/Order_Modifiers/Table_Views/Order_Modifier_Table.php
Outdated
Show resolved
Hide resolved
src/Tickets/Commerce/Order_Modifiers/Table_Views/Order_Modifier_Table.php
Outdated
Show resolved
Hide resolved
| // Set the items for the table. | ||
| $this->items = $data; | ||
| // Get the total number of items. | ||
| $total_items = $this->modifier->find_count_by_search( [ 'search_term' => $search ] ); |
There was a problem hiding this comment.
This does a second query - can't we just count the results above (pre-limit)?
There was a problem hiding this comment.
can't we just count the results above (pre-limit)?
Doing that, we'd need to run a query without the limit in place. Otherwise the limit will mean we only get the count according to the limit.
I did some research into the counting. I had intended to use SQL_CALC_FOUND_ROWS (the way WP_Query does it), and what I found was that it was less efficient than doing a second COUNT() query for the same results (minus the limits).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-2268
🗒️ Description
This PR makes the following changes to the order modifier database queries:
QueryBuilderobjects to create the queries instead of relying on direct stringslimit- limit the number of results returned, with a default of 10.order- specify ordering ASC or DESC.orderby- specify what column to order the results by. Defaults toid.offset- specify how many results to skip before returning results.page- specify what page of results to retrieve. Overridesoffset.status- specify an array of statuses for the results🎥 Artifacts
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.