Update order modifier queries

changelog/feature-ET-2268-update-modifier-queries

@@ -0,0 +1,4 @@
+Significance: minor
+Type: performance
+
+Enhance the performance of order modifier database queries [ET-2268]

src/Tickets/Commerce/Order_Modifiers/API/Fees.php

@@ -62,9 +62,8 @@ public function __construct(
 		Manager $manager
 	) {
 		parent::__construct( $container );
-		$this->modifiers_repository = $fee_repository;
-		$this->relationships        = $relationships;
-		$this->manager              = $manager;
+		$this->relationships = $relationships;
+		$this->manager       = $manager;
 	}
 
 	/**

src/Tickets/Commerce/Order_Modifiers/Admin/Order_Modifier_Fee_Metabox.php

@@ -102,7 +102,6 @@ public function __construct(
 		$this->manager           = $manager;
 
 		// Set up the order modifiers repository for accessing fee data.
-		$this->modifiers_repository                    = $fees_repository;
 		$this->order_modifiers_relationship_repository = $order_modifier_relationship;
 	}
 

src/Tickets/Commerce/Order_Modifiers/Models/Order_Modifier.php

@@ -16,7 +16,7 @@
 use TEC\Common\StellarWP\Models\Model;
 use TEC\Common\StellarWP\Models\ModelQueryBuilder;
 use TEC\Tickets\Commerce\Order_Modifiers\Data_Transfer_Objects\Order_Modifier_DTO;
-use TEC\Tickets\Commerce\Order_Modifiers\Repositories\Order_Modifiers as Repository;
+use TEC\Tickets\Commerce\Order_Modifiers\Factory;
 use TEC\Tickets\Commerce\Order_Modifiers\Values\Float_Value;
 use TEC\Tickets\Commerce\Order_Modifiers\Values\Percent_Value;
 use TEC\Tickets\Commerce\Order_Modifiers\Values\Positive_Integer_Value;
@@ -84,7 +84,7 @@ public static function find( $id ): ?self {
 			return null;
 		}
 
-		return ( new Repository( static::$order_modifier_type ) )->find_by_id( $id );
+		return Factory::get_repository_for_type( static::$order_modifier_type )->find_by_id( $id );
 	}
 
 	/**
@@ -116,7 +116,7 @@ public static function create( array $attributes ): self {
 	 * @return static
 	 */
 	public function save(): self {
-		$repository = new Repository( $this->modifier_type );
+		$repository = Factory::get_repository_for_type( $this->modifier_type );
 		if ( $this->id ) {
 			$repository->update( $this );
 
@@ -136,7 +136,7 @@ public function save(): self {
 	 * @return bool Whether the model was deleted.
 	 */
 	public function delete(): bool {
-		return ( new Repository( $this->modifier_type ) )->delete( $this );
+		return Factory::get_repository_for_type( $this->modifier_type )->delete( $this );
 	}
 
 	/**
@@ -147,7 +147,7 @@ public function delete(): bool {
 	 * @return ModelQueryBuilder The query builder instance.
 	 */
 	public static function query(): ModelQueryBuilder {
-		return tribe( Repository::class )->query();
+		return Factory::get_repository_for_type( static::$order_modifier_type )->prepareQuery();
 	}
 
 	/**

src/Tickets/Commerce/Order_Modifiers/Modifiers/Coupon.php

@@ -173,14 +173,14 @@ public function render_edit( array $context ): void {
 	 * @return array The context data ready for rendering the form.
 	 */
 	public function map_context_to_template( array $context ): array {
-		$order_modifier_coupon_limit_meta_value = $this->order_modifiers_meta_repository->find_by_order_modifier_id_and_meta_key( $context['modifier_id'], 'coupons_available' )->meta_value ?? '';
+		$limit_value = $this->meta_repository->find_by_order_modifier_id_and_meta_key( $context['modifier_id'], 'coupons_available' )->meta_value ?? '';
 		return [
 			'order_modifier_display_name'     => $context['display_name'] ?? '',
 			'order_modifier_slug'             => $context['slug'] ?? $this->generate_unique_slug(),
 			'order_modifier_sub_type'         => $context['sub_type'] ?? '',
 			'order_modifier_fee_amount_cents' => $this->convert_from_raw_amount( $context['raw_amount'] ?? 0 ),
 			'order_modifier_status'           => $context['status'] ?? '',
-			'order_modifier_coupon_limit'     => $order_modifier_coupon_limit_meta_value ?? '',
+			'order_modifier_coupon_limit'     => $limit_value ?? '',
 		];
 	}
 

src/Tickets/Commerce/Order_Modifiers/Modifiers/Fee.php

@@ -269,7 +269,7 @@ public function render_edit( array $context ): void {
 	 * @return array The context data ready for rendering the form.
 	 */
 	public function map_context_to_template( array $context ): array {
-		$order_modifier_fee_applied_to = $this->order_modifiers_meta_repository->find_by_order_modifier_id_and_meta_key( $context['modifier_id'], 'fee_applied_to' )->meta_value ?? '';
+		$order_modifier_fee_applied_to = $this->meta_repository->find_by_order_modifier_id_and_meta_key( $context['modifier_id'], 'fee_applied_to' )->meta_value ?? '';
 		return [
 			'order_modifier_display_name'     => $context['display_name'] ?? '',
 			'order_modifier_slug'             => $context['slug'] ?? $this->generate_unique_slug(),
@@ -295,6 +295,6 @@ public function map_context_to_template( array $context ): array {
 	 * @return array The list of posts related to the modifier.
 	 */
 	public function get_active_on( $modifier_id ) {
-		return $this->order_modifiers_relationship_repository->find_by_modifier_id( $modifier_id );
+		return $this->relationship_repository->find_by_modifier_id( $modifier_id );
 	}
 }