Stop in the workflow run ID to gh run download #3593
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 078bc30 I reintroduced a typo in the variable because of a merge conflict, making it end up as an empty string again. It happened to work because it was the last run (default behavior) but there's no guarantee this is correct. Fixes: 078bc30 ("Rely on gh run download to extract the artifacts (theforeman#3591)")
9 tasks
|
The PR preview for ada147f is available at theforeman-foreman-documentation-preview-pr-3593.surge.sh The following output files are affected by this PR: |
maximiliankolb
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
In 078bc30 I reintroduced a typo in the variable because of a merge conflict, making it end up as an empty string again. It happened to work because it was the last run (default behavior) but there's no guarantee this is correct.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: