improve delete performance for clickhouse #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved the deletion logic in case of reorgs in ClickHouse by implementing partition-aware deletes and disabling lightweight delete synchronization.
What changed?
lightweight_deletes_sync
setting (value 0) to ClickHouse configuration. This will make the deletes async, so processing does not need to wait for it to finishdeleteBatch
function into specific delete functions for blocks, logs, transactions, and traces, which will improve performance due to having all of the order by keys definedWhy make this change?
The previous deletion method was inefficient and could cause performance issues in ClickHouse.