feature: Update Validator and ToBeValidated

sep490-idp/src/main/java/sep490/idp/dto/SignupDTO.java

@@ -4,13 +4,13 @@
 import jakarta.validation.constraints.Size;
 import lombok.Getter;
 import lombok.Setter;
-import sep490.idp.validation.ToValidated;
+import sep490.idp.validation.ToBeValidated;
 
 import static sep490.common.api.utils.CommonConstant.*;
 
 @Getter
 @Setter
-public class SignupDTO implements ToValidated {
+public class SignupDTO extends ToBeValidated {
 
     @Pattern(regexp = EMAIL_PATTERN, message = "{validation.email.invalid}")
     @Size(min = 1, max = 255, message = "{validation.email.length}")

sep490-idp/src/main/java/sep490/idp/service/impl/UserServiceImpl.java

@@ -39,11 +39,12 @@ private SignupResult validateSignupDTO(SignupDTO signupDTO) {
         result.setRedirectUrl("redirect:/login");
         result.setSuccess(true);
 
-        validator.getValidateFirstMessage(signupDTO).ifPresent(msg -> {
+        validator.validate(signupDTO);
+        if (!signupDTO.isValidated()) {
             result.setSuccess(false);
-            result.setErrorMessage(msg);
+            result.setErrorMessage(signupDTO.getFirstErrorMsg().orElse(null));
             result.setRedirectUrl("signup");
-        });
+        }
 
         return result;
     }

sep490-idp/src/main/java/sep490/idp/validation/SignupValidator.java

@@ -7,7 +7,6 @@
 import sep490.idp.dto.SignupDTO;
 import sep490.idp.repository.UserRepository;
 
-import java.util.Optional;
 
 @Component
 @Qualifier("signupValidator")
@@ -18,15 +17,20 @@ public class SignupValidator implements Validator<SignupDTO> {
 
 
     @Override
-    public Optional<String> getValidateFirstMessage(SignupDTO signupDTO) {
-        if (!passwordsMatch(signupDTO)) {
-            return Optional.of("validation.password.invalid.notmatch");
+    public void validate(SignupDTO dto) {
+        if (!passwordsMatch(dto)) {
+            dto.addError("password", "validation.password.invalid.notmatch");
         }
-        if (userRepo.existsByEmail(signupDTO.getEmail())) {
-            return Optional.of("validation.email.invalid.exist");
+        if (userRepo.existsByEmail(dto.getEmail())) {
+            dto.addError("password", "validation.email.invalid.exist");
         }
+        checkValidated(dto);
+    }
 
-        return Optional.empty();
+    private void checkValidated(SignupDTO dto) {
+        if (!dto.getErrorMap().isEmpty()) {
+            dto.setValidated(false);
+        }
     }
 
     private boolean passwordsMatch(SignupDTO signupDTO) {

sep490-idp/src/main/java/sep490/idp/validation/ToBeValidated.java

@@ -0,0 +1,25 @@
+package sep490.idp.validation;
+
+import lombok.Getter;
+import lombok.Setter;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+@Getter
+@Setter
+public abstract class ToBeValidated {
+
+    private boolean validated = false;
+    private Map<String, String> errorMap = new HashMap<>();
+    private String errorMsg;
+
+    public void addError(String key, String errorMsg) {
+        this.errorMap.put(key, errorMsg);
+    }
+
+    public Optional<String> getFirstErrorMsg() {
+        return Optional.ofNullable(this.getErrorMap().entrySet().iterator().next().getValue());
+    }
+}

sep490-idp/src/main/java/sep490/idp/validation/Validator.java

@@ -1,15 +1,13 @@
 package sep490.idp.validation;
 
-import java.util.Optional;
 
-public interface Validator<T extends ToValidated> {
+public interface Validator<T extends ToBeValidated> {
 
 
     /**
-     * Retrieves the first validation message for the given toValidate object.
+     * Validate the whole object and set value to flag and map
      *
      * @param toValidate the object to be validated
-     * @return the first validation message as a string
      */
-    Optional<String> getValidateFirstMessage(T toValidate);
+    void validate(T toValidate);
 }