Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Paseo People to well known chains #411

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Added Paseo People to well known chains #411

merged 10 commits into from
Jan 13, 2025

Conversation

71walceli
Copy link
Contributor

Paseo People chain was added since polkadot-api@1.8.0, so I'm adding it to be used with the light client provider. Please let me know if anything else is needed

Paseo People chain was added since `polkadot-api@1.8.0`, so I'm adding it to be used with the light client provider. Please let me know if anything else is needed
Copy link

changeset-bot bot commented Jan 1, 2025

🦋 Changeset detected

Latest commit: b9c5db6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@reactive-dot/core Minor
@reactive-dot/react Minor
@reactive-dot/vue Minor
@reactive-dot/wallet-ledger Patch
@reactive-dot/wallet-walletconnect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

package.json Outdated
@@ -44,5 +44,8 @@
"husky": "^9.1.7",
"nx": "^20.2.1",
"prettier": "^3.4.2"
},
"dependencies": {
"polkadot-api": "1.8.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed. PAPI is a peer dependency and should be updated as a devDependency in package.json

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are several places that needed to be updated, you can just do a string search for "polkadot-api"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are several places that needed to be updated, you can just do a string search for "polkadot-api"

Yeah, I found other package.jsons that reference it. THose versions should be updated, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I found other package.jsons that reference it. THose versions should be updated, right?

A few of those I found are examples. Do i leave those under dependencies? The ones in packages are to be left in devDependencies?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes should be good leaving them where they are.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

@71walceli 71walceli requested a review from tien January 4, 2025 15:57
@@ -45,11 +45,10 @@
"@tsconfig/recommended": "^1.0.8",
"@tsconfig/strictest": "^2.0.5",
"eslint": "^9.16.0",
"polkadot-api": "^1.7.8",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part need to be kept

"typescript": "^5.7.2",
"vitest": "^2.1.8"
},
"peerDependencies": {
"polkadot-api": "1.x"
"polkadot-api": "^1.8.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safer to use 1.x as the peer dependencies range, to not break existing dapps

@71walceli 71walceli requested a review from tien January 11, 2025 15:10
packages/core/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@tien tien merged commit 6e1ded0 into tien:main Jan 13, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants