-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Paseo People to well known chains #411
Conversation
Paseo People chain was added since `polkadot-api@1.8.0`, so I'm adding it to be used with the light client provider. Please let me know if anything else is needed
🦋 Changeset detectedLatest commit: b9c5db6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
package.json
Outdated
@@ -44,5 +44,8 @@ | |||
"husky": "^9.1.7", | |||
"nx": "^20.2.1", | |||
"prettier": "^3.4.2" | |||
}, | |||
"dependencies": { | |||
"polkadot-api": "1.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed. PAPI is a peer dependency and should be updated as a devDependency in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are several places that needed to be updated, you can just do a string search for "polkadot-api"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are several places that needed to be updated, you can just do a string search for "polkadot-api"
Yeah, I found other package.json
s that reference it. THose versions should be updated, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I found other
package.json
s that reference it. THose versions should be updated, right?
A few of those I found are examples. Do i leave those under dependencies
? The ones in packages
are to be left in devDependencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes should be good leaving them where they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
@@ -45,11 +45,10 @@ | |||
"@tsconfig/recommended": "^1.0.8", | |||
"@tsconfig/strictest": "^2.0.5", | |||
"eslint": "^9.16.0", | |||
"polkadot-api": "^1.7.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part need to be kept
packages/core/package.json
Outdated
"typescript": "^5.7.2", | ||
"vitest": "^2.1.8" | ||
}, | ||
"peerDependencies": { | ||
"polkadot-api": "1.x" | ||
"polkadot-api": "^1.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safer to use 1.x
as the peer dependencies range, to not break existing dapps
Paseo People chain was added since
polkadot-api@1.8.0
, so I'm adding it to be used with the light client provider. Please let me know if anything else is needed