Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Paseo People to well known chains #411

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Added Paseo People to well known chains #411

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
307d9ba
Added Paseo People to well known chains
71walceli Jan 1, 2025
e338d8c
Added changelist
Jan 1, 2025
09da1b7
Updated polkadot-api
Jan 1, 2025
8d5d1b7
Merge branch 'main' into patch-1
Jan 1, 2025
b39d05d
Fixed way of adding Paseo chain, as it must be passed in single object
Jan 2, 2025
7729e32
Updated `polkadot-api` for examples
Jan 4, 2025
e0258a1
Updated `polkadot-api` peer deps
Jan 4, 2025
d19ae0c
Reviewed deps
Jan 11, 2025
b9c5db6
Apply suggestions from code review
tien Jan 13, 2025
7230b5f
build: update yarn.lock
tien Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/few-penguins-rest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@reactive-dot/core": minor
---

Added Paseo People relay chain

`polkadot-api` v1.8.0 added the parachain.
tien marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion examples/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@reactive-dot/wallet-walletconnect": "workspace:^",
"date-fns": "^4.1.0",
"jotai-devtools": "^0.10.1",
"polkadot-api": "^1.7.8",
"polkadot-api": "^1.8.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-error-boundary": "^4.1.2",
Expand Down
2 changes: 1 addition & 1 deletion examples/vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"@polkadot-api/descriptors": "portal:.papi/descriptors",
"@reactive-dot/vue": "workspace:^",
"polkadot-api": "^1.7.8",
"polkadot-api": "^1.8.0",
"vue": "^3.5.12"
},
"devDependencies": {
Expand Down
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,8 @@
"husky": "^9.1.7",
"nx": "^20.2.1",
"prettier": "^3.4.2"
},
"dependencies": {
"polkadot-api": "1.8.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed. PAPI is a peer dependency and should be updated as a devDependency in package.json

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are several places that needed to be updated, you can just do a string search for "polkadot-api"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are several places that needed to be updated, you can just do a string search for "polkadot-api"

Yeah, I found other package.jsons that reference it. THose versions should be updated, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I found other package.jsons that reference it. THose versions should be updated, right?

A few of those I found are examples. Do i leave those under dependencies? The ones in packages are to be left in devDependencies?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes should be good leaving them where they are.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

tien marked this conversation as resolved.
Show resolved Hide resolved
}
}
3 changes: 1 addition & 2 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,10 @@
"@tsconfig/recommended": "^1.0.8",
"@tsconfig/strictest": "^2.0.5",
"eslint": "^9.16.0",
"polkadot-api": "^1.7.8",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part need to be kept

"typescript": "^5.7.2",
"vitest": "^2.1.8"
},
"peerDependencies": {
"polkadot-api": "1.x"
"polkadot-api": "^1.8.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safer to use 1.x as the peer dependencies range, to not break existing dapps

}
}
5 changes: 4 additions & 1 deletion packages/core/src/providers/light-client/wellknown-chains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ export const wellknownChains = {
],
paseo: [
() => import("polkadot-api/chains/paseo"),
{ paseo_asset_hub: () => import("polkadot-api/chains/paseo_asset_hub") },
{
paseo_asset_hub: () => import("polkadot-api/chains/paseo_asset_hub"),
paseo_people: () => import("polkadot-api/chains/paseo_people"),
},
],
westend: [
() => import("polkadot-api/chains/westend2"),
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@tsconfig/strictest": "^2.0.5",
"@types/react": "^19.0.1",
"eslint": "^9.16.0",
"polkadot-api": "^1.7.8",
"polkadot-api": "^1.8.0",
"react": "^19.0.0",
"typescript": "^5.7.2"
},
Expand Down
Loading