refactor: Reorganize Build Process #1867
Conversation
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com> This significantly reworks the build system for Bluefin/Aurora. Changes: Consolidates Workflows Removes Surface and Asus images in favor of a single HWE image Refwrite of local dev Justfile Reorganization and Consolidation of build files Add new files Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
m2Giles
force-pushed
the
refactor-build
branch
from
46f4775 to
18fc0b0
Compare
This reverts commit 18fc0b0.
|
I see how to pass strings that turn into json objects now. I think we will still want a matrix in the reusable build but it just takes inputs. |
|
@befanyt got any opinions here? If we're going to build a new world we might as well get new eyes. 😄 |
This cleans up whitespace and EOL to be consistent. Only ran across .github, build_files, just and root dir files. This refactor seems like a good time to introduce it, even if it's not always running, it's a standard.
There was a problem hiding this comment.
Looking this over... this is a hugely valuable effort.
However, I think we should go one step further. We should be using the value of the just recipes in our github action workflow.
At the least, the just build recipe should be used in reusable-build.yml to build the images.
All the tagging logic probably makes sense to remain in the workflow since that's external to the container build itself. Similarly, the push operation doesn't need to be in just, and it ties closely to the tags.
We could possibly use just build-rechunk in the workflow as well... Looking for feedback from @m2Giles on that.
But the primary value from doing this is ability to build container images the same way both local and in github actions. That's huge!
Fixing a bug in the image build can be validated before pushing to a PR even.
|
I think the only thing needed to change to make that a reality is to make sure build container and rechunk can run completely as root. The only major concern is not having enough space on builds when copying to the rootful podman store. |
Ah, like an additional flag to the build recipe to run it as root? Yes, then it would match workflow behavior.
This should be addressed by running build as root, no? |
|
I would run the just command with sudo. I've already put in a bunch of sudoif's so this should be just testing to make sure it works as intended. I may add the secureboot check to the justfile. |
This avoids confusion where we actually do use "fedora_version" to reference Fedora version numbers (40, 41, etc), but for the input and matrix use cases we actually intend to refer to the Bluefin streams: gts, stable, latest, beta
|
After further review and discussion, while we DO want to make use of the new and improved just recipes within the github workflows, that effort can be iterated on. As is, this is already large and holding up some needed fixes. So we should make an issue to reduce the workflow specific code by calling just instead. I'm continuing to review the existing changes tonight. So far looking nice. |
There was a problem hiding this comment.
I have spent a bunch of time testing the justfile locally, looking through the build script changes (made a few changes there myself to fix numbering of build scripts), looking through the workflow yaml (fixed some naming conventions), and looking at the GREEN successful builds validating the podman build args.
I think this is looking good.
A great improvement and we'll keep on making it better.
Thanks @m2Giles !
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com> Co-authored-by: Benjamin Sherman <benjamin@holyarmy.org>
This significantly reworks the build system for Bluefin/Aurora.
Changes:
Consolidates Workflows
Removes Surface and Asus images in favor of a single HWE image
Rewrite of local dev Justfile
Reorganization and Consolidation of build files
Add new files
Closes: #1841