add ~ 5 minutes leeway to determine whether a date/time is in the past #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbugni
force-pushed
the
feature/time-in-past-comparison
branch
from
3b70a32 to
844ebe3
Compare
pbugni
approved these changes
Jan 14, 2025
| @@ -468,7 +468,8 @@ export function isInPast(dateString) { | |||
| const today = new Date(); | |||
| const targetDate = new Date(dateString); | |||
| if (!isValid(targetDate)) return false; | |||
| return targetDate < today; | |||
| const diff = (today - targetDate); // in miniseconds | |||
| return diff > (1000 * 60 * 5); // this will check if diff is 5 minutes or more | |||
There was a problem hiding this comment.
i'd love a comment that explains the buffer, i.e.:
pad by 5 mins to give system time to transmit message, rather than indicate no next message time during processing
added 2 commits
January 14, 2025 14:35
…uwcirg/cosri-patientsearch into feature/time-in-past-comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Slack convo
When determine whether date/time for the Next Message column is in the past (see here), add 5 minutes for comparison.