Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ~ 5 minutes leeway to determine whether a date/time is in the past #236

Merged
merged 4 commits into from
Jan 15, 2025
Merged

add ~ 5 minutes leeway to determine whether a date/time is in the past #236

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b70a32
add ~ 5 minutes leeway to determine whether a date/time is in the past
Jan 14, 2025
844ebe3
add ~ 5 minutes leeway to determine whether a date/time is in the past
Jan 14, 2025
b05d0a3
Merge branch 'feature/time-in-past-comparison' of https://github.com/…
Jan 14, 2025
5c9edef
add comment per feedback
Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion patientsearch/src/js/helpers/utility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,10 @@ export function isInPast(dateString) {
const today = new Date();
const targetDate = new Date(dateString);
if (!isValid(targetDate)) return false;
return targetDate < today;
const diff = (today - targetDate); // in miniseconds
// this will check if diff is 5 minutes or more
// e.g. pad by 5 mins to give system time to transmit message, rather than indicate no next message time during processing
return diff > (1000 * 60 * 5);
}

/*
Expand Down
Loading