Merge pull request #289 from ZeroFairy/develop

update the apriori fix bug
vianneynara · Dec 18, 2024 · fb9046e · fb9046e
2 parents 7082e7f + 60f97cb
commit fb9046e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/main/java/dev/kons/kuenyawz/repositories/ProductRepository.java b/src/main/java/dev/kons/kuenyawz/repositories/ProductRepository.java
@@ -15,9 +15,6 @@ public interface ProductRepository extends JpaRepository<Product, Long>, JpaSpec
 
 	List<Product> findAllByCategoryIsAndNameLikeIgnoreCase(Product.Category category, String name);
 
-	@Query("SELECT p.productId FROM Product p")
-	List<Long> findAllIds();
-
 	@Query("SELECT p.productId FROM Product p WHERE p.available=TRUE")
 	List<Long> findAllAvailableIds();
 }
diff --git a/src/main/java/dev/kons/kuenyawz/services/logic/RecommenderServiceImpl.java b/src/main/java/dev/kons/kuenyawz/services/logic/RecommenderServiceImpl.java
@@ -150,7 +150,7 @@ private List<ProductDto> oldRecommender(Long productId, Boolean addRandom) {
 	private Long addOneRandom(Long productId, Set<Long> excludeSet) {
 		excludeSet.add(productId);
 
-		List<Long> allProductIds = productRepository.findAllIds();
+		List<Long> allProductIds = productRepository.findAllAvailableIds();
 		List<Long> filteredProductIds = allProductIds.stream()
 				.filter(id -> !excludeSet.contains(id))
 				.collect(Collectors.toList());