Add short link generation #4
Conversation
|
reviewing it! |
src/klipse/utils.cljs
Outdated
| :headers {"accept" "application/json" "content-type" "application/json"} | ||
| :query-params {:format "simple" :url "https://google.com"}}))] | ||
| (if-not (= (:status response) 200) | ||
| ( |
There was a problem hiding this comment.
better to move alert and print into a separate function outside of fetch-shortened-url
There was a problem hiding this comment.
Done, although I can't seem to get the URL to output on to the Klipse output. Is there another function I need to call besides print to make that happen?
|
@jayhoogle I am not able to generate a short link when testing locally.
I am getting a bad request error |
|
@viebel that's because |
|
What we should do is to provide a way to disable the shortening url feature via a url parameter named klipse-app/src/klipse/utils.cljs Line 22 in 46809aa |
| @@ -9,6 +9,31 @@ | |||
| [cljs.core.async :refer [timeout <! chan put!]] | |||
| [cemerick.url :refer [url]])) | |||
|
|
|||
| (defn show-url | |||
| [url] | |||
| ( | |||
There was a problem hiding this comment.
Remove unnecessary wrapping parentheses
|
@jayhoogle What are the license terms of is.gd ? I am not comfortable with the CORS hack that you used. |
| {:with-credentials? false | ||
| :headers {"accept" "application/json" "content-type" "application/json"} | ||
| :query-params {:format "simple" :url current}}))] | ||
| (if-not (= (:status response) 200) |
| @@ -29,9 +54,18 @@ | |||
| (assoc-in [:query (name key)] value) | |||
| str)) | |||
|
|
|||
| (defn process-url [base-url input] | |||
| (let [a (add-url-parameter base-url :cljs_in input)] | |||
| (add-url-parameter :cljs_in input))) | ||
| (-> | ||
| (if base-url (url base-url) (current-url)) | ||
| (process-url input) |
There was a problem hiding this comment.
always close parentheses on the above line
Moved across changes from the main repo PR @viebel.