Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link shortening #387

Closed
wants to merge 5 commits into from
Closed

Conversation

jayhoogle
Copy link

Closes #130

Uses the Cutt.ly API to generate a short link when the user hits Ctrl+S. If there's an issue generating the short link, the current URL is returned instead.

Checking with the Cutt.ly team to see if localhost can be added as an accepted origin as those URLs currently fail to convert to a short link, and also to see if URL generation can be limited to the origins localhost and app.klipse.tech.

@jayhoogle
Copy link
Author

@viebel here's the PR for my implementation of a link shortener. If you'd prefer a system that doesn't require a key, there is also the is.gd API which would provide much the same functionality but with a little less code, but still no ability to convert localhost URLs to short links.

@jayhoogle
Copy link
Author

@viebel I haven't heard from Cutt.ly so I've reverted to using is.gd so the code is cleaner and a little faster to run, too. Also means there are no API keys in the code. Let me know whether you're happy for this to merge.

@viebel
Copy link
Owner

viebel commented Jan 5, 2021

@jayhoogle Sounds good. Will review it soon

@jayhoogle
Copy link
Author

@viebel great, thanks!

@viebel
Copy link
Owner

viebel commented Jan 9, 2021

@jayhoogle The link shortening feature only makes sense in the Klipse web app. Please submit a PR to Klipse app repo.

@jayhoogle
Copy link
Author

Closing in favour of this.

@jayhoogle jayhoogle closed this Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shorter urls for app.klipse.tech
3 participants