-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts performance measurement tool proposal #1750
Conversation
Really appreciate seeing this grant application! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application. It looks good to me, and I'm happy to go ahead with it as well as share it with the rest of the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application, @smiasojed. Generally happy with the application, just one question below.
applications/contracts-tool.md
Outdated
| 1. | License | GPLv3 | | ||
| 2. | Documentation | We will provide both **inline documentation** of the code and a basic **tutorial** that explains how a user can spin up test net and run contracts with transactions. | | ||
| 3. | Testing and Testing Guide | Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. | | ||
| 4. | Updated evm contracts | We will update tool with support for newest Moonbeam parachain. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "updated EVM contracts"? And is there anything specific to Moonbeam about any of the deliverables that wouldn't also work for other EVM-compatible parachains, or why are you singling out Moonbeam here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing specific. Moonbeam is just a good candidate to trigger a github action and take measurements on it. In our case, we want to have a daily contract comparison, so we need to find a representative parachain to measure against.
By update of evm contracts I mean updating the smart-bench dependencies being used for contracts execution on pallet-evm based parachain. Similar work I have already done for ink contracts.
Thanks for the application @smiasojed it looks good and it's cool to see support for Solang as well. Just a couple of minor suggestions:
Thanks! |
Thanks @smiasojed I see you changed the first milestone but not the second, this would go for that one as well. |
I missed it, I am sorry. Now should be better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
We are planning to close the 1st milestone until 09.07.2023 |
Hi @smiasojed how is the 2nd milestone coming along? |
Hi @keeganquigley, We've encountered a delay, and we are currently working on updating smart-bench dependencies to the newest versions. As for phase 2, half of it has been completed, and we estimate that we should be ready by the end of the year. |
Thanks @smiasojed in this case could you please file an amendment to reflect the changes and extend the timeline? You can amend the original application. Thanks! |
Hi @smiasojed are you still planning to submit an amendment? |
Hey @keeganquigley I did it: #2124 |
Hi @smiasojed. How is M2 progressing? |
Hi @semuelle, we have all the code in pull requests, and we are waiting for approvals from the Parity team's side. |
Hi @smiasojed just checking in for an update on M2? |
Hi @keeganquigley, our PRs are still waiting for approval: |
Hi @smiasojed since the first PR has been merged feel free to go ahead and submit the delivery in the milestone delivery repo. That way we can start evaluating and it will take the pressure off of the timeline. Besides I'm not seeing a hard requirement in the milestone deliverables that says they need to be merged into the codebase, so we'll probably be able to go ahead and pass it as is. |
Hi @keeganquigley, thanks! I will do it next week. |
Project Abstract
The key objective of this grant is to build a tool which allows to compare contracts performance and to track its regressions.
Tool is integrated with CI and triggered by a release of pallet-evm or pallet-contracts based parachain. It measures the contract performance and allows for its visualization.
Grant level
Application Checklist
project_name.md
).@smiasojed:matrix.org
(change the homeserver if you use a different one)