Skip to content

Commit

Permalink
Fixed code smell
Browse files Browse the repository at this point in the history
  • Loading branch information
w3stling committed Aug 8, 2022
1 parent e5142f7 commit 591c2d2
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void getIssuer_EmptyString() throws IOException {
@Test
void getIssuer_null() {
assertThrows(IllegalArgumentException.class, () ->
FreeTextQueryBuilder.issuer(null).build());
FreeTextQueryBuilder.issuer(null));
}


Expand All @@ -103,7 +103,7 @@ void getPDMR_Jo() throws IOException {
@Test
void getPDMR_null() {
assertThrows(IllegalArgumentException.class, () ->
FreeTextQueryBuilder.pdmr(null).build());
FreeTextQueryBuilder.pdmr(null));
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void badTransactionToDate() {
LocalDate to = null;

assertThrows(IllegalArgumentException.class, () ->
TransactionQueryBuilder.transactions(from, to).build());
TransactionQueryBuilder.transactions(from, to));
}

@Test
Expand Down Expand Up @@ -97,7 +97,7 @@ void badPublicationFromDate() {
LocalDate to = LocalDate.of(2018, 3,1);

assertThrows(IllegalArgumentException.class, () ->
TransactionQueryBuilder.publications(from, to).build());
TransactionQueryBuilder.publications(from, to));
}


Expand All @@ -107,14 +107,14 @@ void badPublicationToDate() {
LocalDate to = null;

assertThrows(IllegalArgumentException.class, () ->
TransactionQueryBuilder.publications(from, to).build());
TransactionQueryBuilder.publications(from, to));
}


@Test
void badPublicationsPastDays() {
assertThrows(IllegalArgumentException.class, () ->
TransactionQueryBuilder.publicationsLastDays(-1).build());
TransactionQueryBuilder.publicationsLastDays(-1));
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ private Transaction getDefaultTransaction() {
}



@Test
@SuppressWarnings("java:S5961")
void equalsTest() {
Transaction transaction1 = getDefaultTransaction();

Expand Down

0 comments on commit 591c2d2

Please sign in to comment.