Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(weave): working with Bedrock guide #3342

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

J2-D2-3PO
Copy link
Contributor

@J2-D2-3PO J2-D2-3PO commented Jan 8, 2025

https://wandb.atlassian.net/browse/DOCS-1075

This PR adds a new guide in Integrations for Amazon Bedrock. All code samples are taken from our published blog https://wandb.ai/amazon-wandb/bedrock-weave/reports/Getting-Started-with-Amazon-Bedrock-and-W-B-Weave--Vmlldzo3NTAxMTgx and the content itself is modified and edited to fit in the docs.

Supersedes #3108

@J2-D2-3PO J2-D2-3PO self-assigned this Jan 8, 2025
@J2-D2-3PO J2-D2-3PO marked this pull request as ready for review January 8, 2025 02:28
@J2-D2-3PO J2-D2-3PO requested a review from a team as a code owner January 8, 2025 02:28
@circle-job-mirror
Copy link

circle-job-mirror bot commented Jan 8, 2025

@J2-D2-3PO J2-D2-3PO force-pushed the bedrock-integration branch from 7cd5386 to 054b8a6 Compare January 9, 2025 20:19
@J2-D2-3PO
Copy link
Contributor Author

J2-D2-3PO commented Jan 9, 2025

@tssweeney per your point that this Bedrock guide doesn't belong in Integrations and should be called "Working with Bedrock" or something similar:

- There's not really a good place to put content like this in the existing docs structure. The closest is Cookbooks, but those all have notebooks and are auto-generated. Anywhere else in the docs, it would get lost or clog up the existing structure. So, I created a new top level sub category Tutorials under Documentation to contain tutorials that don't have a NB associated with them (see screenshot). If we feel strongly about this, I can put elsewhere, but I think this is the best bet atm, assuming we aren't doing the larger docs restruct yet <- This comment isn't relevant anymore, as someone already went ahead and merged a bedrock guide in Integrations in #3145. So, let's just keep that structure, and move my content to our cookbooks section. I really don't think we should add any more subsections to the docs menu, it's already cluttered

  • I agree on the rename, updated

@J2-D2-3PO J2-D2-3PO changed the title docs(weave): document Bedrock integration docs(weave): working with Bedrock guide Jan 9, 2025
@J2-D2-3PO J2-D2-3PO requested a review from tssweeney January 9, 2025 20:26
@J2-D2-3PO J2-D2-3PO requested a review from a team as a code owner January 13, 2025 16:56
@J2-D2-3PO J2-D2-3PO requested a review from scottire January 14, 2025 17:04
@J2-D2-3PO J2-D2-3PO removed the request for review from scottire January 22, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant