clippy 1.79 lints

warthog618 · Mar 22, 2024 · df5134e · df5134e
1 parent 48782ee
commit df5134e
Show file tree

Hide file tree

Showing 34 changed files with 3 additions and 35 deletions.
diff --git a/embedded-hal/examples/async_io_wait_for_edges.rs b/embedded-hal/examples/async_io_wait_for_edges.rs
@@ -7,7 +7,6 @@
 use anyhow::Context;
 use embedded_hal_async::digital::Wait;
 use gpiocdev_embedded_hal::async_io::InputPin;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let mut pin = InputPin::new("/dev/gpiochip0", 23).context("Failed to request line")?;

diff --git a/embedded-hal/examples/async_std_wait_for_edges.rs b/embedded-hal/examples/async_std_wait_for_edges.rs
@@ -7,7 +7,6 @@
 use anyhow::Context;
 use embedded_hal_async::digital::Wait;
 use gpiocdev_embedded_hal::async_io::InputPin;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let mut pin = InputPin::new("/dev/gpiochip0", 23).context("Failed to request line")?;

diff --git a/embedded-hal/examples/get_pin_value.rs b/embedded-hal/examples/get_pin_value.rs
@@ -5,7 +5,6 @@
 // Basic example of reading a single line.
 
 use embedded_hal::digital::InputPin;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let mut pin = gpiocdev_embedded_hal::InputPin::new("/dev/gpiochip0", 22)?;

diff --git a/embedded-hal/examples/pulse_pin_value.rs b/embedded-hal/examples/pulse_pin_value.rs
@@ -5,7 +5,6 @@
 // Basic example of pulsing a single line.
 
 use embedded_hal::digital::{OutputPin, PinState};
-use std::result::Result;
 use std::thread;
 use std::time::Duration;
 

diff --git a/embedded-hal/examples/toggle_pin_value.rs b/embedded-hal/examples/toggle_pin_value.rs
@@ -5,7 +5,6 @@
 // Basic example of toggling a single line.
 
 use embedded_hal::digital::{PinState, StatefulOutputPin};
-use std::result::Result;
 use std::thread;
 use std::time::Duration;
 

diff --git a/embedded-hal/examples/tokio_wait_for_edges.rs b/embedded-hal/examples/tokio_wait_for_edges.rs
@@ -7,7 +7,6 @@
 use anyhow::Context;
 use embedded_hal_async::digital::Wait;
 use gpiocdev_embedded_hal::tokio::InputPin;
-use std::result::Result;
 
 #[tokio::main(flavor = "current_thread")]
 async fn main() -> Result<(), Box<dyn std::error::Error>> {

diff --git a/embedded-hal/src/lib.rs b/embedded-hal/src/lib.rs
@@ -62,7 +62,6 @@
 //! # Ok(())
 //! # }
 //! ```
-use std::convert::TryFrom;
 use std::path::Path;
 
 use embedded_hal::digital::PinState;

diff --git a/lib/examples/async_io_watch_line_value.rs b/lib/examples/async_io_watch_line_value.rs
@@ -8,7 +8,6 @@ use anyhow::Context;
 use gpiocdev::async_io::AsyncRequest;
 use gpiocdev::line::EdgeDetection;
 use gpiocdev::Request;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let req = AsyncRequest::new(

diff --git a/lib/examples/async_std_watch_line_value.rs b/lib/examples/async_std_watch_line_value.rs
@@ -8,7 +8,6 @@ use anyhow::Context;
 use gpiocdev::async_io::AsyncRequest;
 use gpiocdev::line::EdgeDetection;
 use gpiocdev::Request;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let offset = 23;

diff --git a/lib/examples/get_line_value.rs b/lib/examples/get_line_value.rs
@@ -6,7 +6,6 @@
 
 use gpiocdev::line::Bias;
 use gpiocdev::Request;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let offset = 22;

diff --git a/lib/examples/get_multiple_line_values.rs b/lib/examples/get_multiple_line_values.rs
@@ -6,7 +6,6 @@
 
 use gpiocdev::line::Values;
 use gpiocdev::Request;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     // request multiple input lines

diff --git a/lib/examples/pulse_line_value.rs b/lib/examples/pulse_line_value.rs
@@ -6,7 +6,6 @@
 
 use gpiocdev::line::Value;
 use gpiocdev::Request;
-use std::result::Result;
 use std::thread;
 use std::time::Duration;
 

diff --git a/lib/examples/pulse_multiple_line_values.rs b/lib/examples/pulse_multiple_line_values.rs
@@ -6,7 +6,6 @@
 
 use gpiocdev::line::{Value, Values};
 use gpiocdev::Request;
-use std::result::Result;
 use std::time::Duration;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {

diff --git a/lib/examples/toggle_line_value.rs b/lib/examples/toggle_line_value.rs
@@ -7,7 +7,6 @@
 use anyhow::Context;
 use gpiocdev::line::Value;
 use gpiocdev::Request;
-use std::result::Result;
 use std::time::Duration;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {

diff --git a/lib/examples/toggle_multiple_line_values.rs b/lib/examples/toggle_multiple_line_values.rs
@@ -7,7 +7,6 @@
 use anyhow::Context;
 use gpiocdev::line::Value;
 use gpiocdev::Request;
-use std::result::Result;
 use std::thread;
 use std::time::Duration;
 

diff --git a/lib/examples/tokio_watch_line_value.rs b/lib/examples/tokio_watch_line_value.rs
@@ -8,7 +8,6 @@ use anyhow::Context;
 use gpiocdev::line::{EdgeDetection, Values};
 use gpiocdev::tokio::AsyncRequest;
 use gpiocdev::Request;
-use std::result::Result;
 
 #[tokio::main(flavor = "current_thread")]
 async fn main() -> Result<(), Box<dyn std::error::Error>> {

diff --git a/lib/examples/watch_line_value.rs b/lib/examples/watch_line_value.rs
@@ -7,7 +7,6 @@
 use anyhow::Context;
 use gpiocdev::line::EdgeDetection;
 use gpiocdev::Request;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     // request the line with edge detection to receive events

diff --git a/lib/examples/watch_multiple_line_values.rs b/lib/examples/watch_multiple_line_values.rs
@@ -7,7 +7,6 @@
 use anyhow::Context;
 use gpiocdev::line::EdgeDetection;
 use gpiocdev::Request;
-use std::result::Result;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let offsets = [23, 12];

diff --git a/lib/tests/chip.rs b/lib/tests/chip.rs
@@ -120,7 +120,7 @@ mod chip {
     use gpiocdev::chip::Chip;
     use gpiocdev::request::Request;
     use gpiocdev::Error::GpioChip as ChipError;
-    use gpiosim::{Bank, Direction, Simpleton};
+    use gpiosim::{Direction, Simpleton};
     use std::time::Duration;
 
     // a collection of chips with named and hogged lines for find and info tests

diff --git a/lib/tests/lib.rs b/lib/tests/lib.rs
@@ -114,7 +114,7 @@ fn find_named_lines() {
         assert_eq!(&l.chip, sim.chips()[1].dev_path());
         assert_eq!(l.info.offset, 5);
     }
-    assert!(found.get(&"fls nada").is_none());
+    assert!(found.contains_key(&"fls nada"));
 }
 
 #[test]

diff --git a/uapi/src/common.rs b/uapi/src/common.rs
@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0 OR MIT
 
-use libc::{self, c_long, pollfd, time_t, timespec, POLLIN};
+use libc::{c_long, pollfd, time_t, timespec, POLLIN};
 use std::ffi::OsStr;
 use std::fs::File;
 use std::mem::{self, MaybeUninit};
@@ -25,7 +25,6 @@ macro_rules! ior {
         ioctl_sys::ior!(IOCTL_MAGIC, $nr, mem::size_of::<$dty>()) as ::std::os::raw::c_ulong
     };
 }
-pub(crate) use ior;
 
 macro_rules! iorw {
     ($nr:expr, $dty:ty) => {

diff --git a/uapi/src/v2.rs b/uapi/src/v2.rs
@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0 OR MIT
 
 use bitflags::bitflags;
-use std::convert::TryFrom;
 use std::fmt;
 use std::fs::File;
 use std::mem;

diff --git a/uapi/tests/v1/get_chip_info.rs b/uapi/tests/v1/get_chip_info.rs
@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0 OR MIT
 
 use super::*;
-use gpiocdev_uapi::v1::get_chip_info;
 #[test]
 fn check_info() {
     let s = gpiosim::builder()

diff --git a/uapi/tests/v1/get_line_values.rs b/uapi/tests/v1/get_line_values.rs
@@ -4,7 +4,6 @@
 
 use super::*;
 use crate::common::wait_propagation_delay;
-use gpiocdev_uapi::v1::{get_line_values, set_line_values};
 
 #[test]
 fn on_input() {

diff --git a/uapi/tests/v1/set_line_config.rs b/uapi/tests/v1/set_line_config.rs
@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0 OR MIT
 
 use super::*;
-use gpiocdev_uapi::v1::{set_line_config, HandleConfig};
 
 #[test]
 fn check_info() {

diff --git a/uapi/tests/v1/set_line_values.rs b/uapi/tests/v1/set_line_values.rs
@@ -4,7 +4,6 @@
 
 use super::*;
 use crate::common::wait_propagation_delay;
-use gpiocdev_uapi::v1::set_line_values;
 
 #[test]
 fn on_output() {

diff --git a/uapi/tests/v1/unwatch_line_info.rs b/uapi/tests/v1/unwatch_line_info.rs
@@ -4,7 +4,6 @@
 
 use super::*;
 use crate::common::EVENT_WAIT_TIMEOUT;
-use gpiocdev_uapi::v1::{unwatch_line_info, wait_event, watch_line_info};
 
 #[test]
 fn unwatch() {

diff --git a/uapi/tests/v1/watch_line_info.rs b/uapi/tests/v1/watch_line_info.rs
@@ -4,7 +4,6 @@
 
 use super::*;
 use crate::common::EVENT_WAIT_TIMEOUT;
-use gpiocdev_uapi::v1::{wait_event, watch_line_info};
 
 #[test]
 fn watch() {

diff --git a/uapi/tests/v2/get_line_info.rs b/uapi/tests/v2/get_line_info.rs
@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0 OR MIT
 
 use super::*;
-use gpiocdev_uapi::v2::{get_line_info, LineFlags};
 
 #[test]
 fn check_info() {

diff --git a/uapi/tests/v2/get_line_values.rs b/uapi/tests/v2/get_line_values.rs
@@ -4,7 +4,6 @@
 
 use super::*;
 use crate::common::wait_propagation_delay;
-use gpiocdev_uapi::v2::{get_line_values, set_line_values};
 
 #[test]
 fn on_input() {

diff --git a/uapi/tests/v2/set_line_config.rs b/uapi/tests/v2/set_line_config.rs
@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0 OR MIT
 
 use super::*;
-use gpiocdev_uapi::v2::{set_line_config, LineConfig};
 
 #[test]
 fn check_info() {

diff --git a/uapi/tests/v2/set_line_values.rs b/uapi/tests/v2/set_line_values.rs
@@ -5,7 +5,6 @@
 use super::*;
 
 use crate::common::wait_propagation_delay;
-use gpiocdev_uapi::v2::set_line_values;
 
 #[test]
 fn on_output() {

diff --git a/uapi/tests/v2/unwatch_line_info.rs b/uapi/tests/v2/unwatch_line_info.rs
@@ -4,7 +4,6 @@
 
 use super::*;
 use crate::common::EVENT_WAIT_TIMEOUT;
-use gpiocdev_uapi::v2::{unwatch_line_info, wait_event, watch_line_info};
 
 #[test]
 fn unwatch() {

diff --git a/uapi/tests/v2/watch_line_info.rs b/uapi/tests/v2/watch_line_info.rs
@@ -4,7 +4,6 @@
 
 use super::*;
 use crate::common::EVENT_WAIT_TIMEOUT;
-use gpiocdev_uapi::v2::{wait_event, watch_line_info};
 
 #[test]
 fn watch() {