-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/optipng module issue on armx64 #198
Conversation
WalkthroughThis update primarily focuses on adjusting the webpack configuration to disable Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabled: false | ||
// NOTE: optipng is disabled as it causes errors in some Mac M1 & M2 environments | ||
// Try enabling it in your environment by switching the config to: | ||
// enabled: true, | ||
// optimizationLevel: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling optipng
optimization for Mac M1 & M2 environments is a pragmatic solution to ensure compatibility across different hardware architectures. However, it's important to document this change prominently in the project's README or developer documentation, not just within the code comments. This ensures that all developers are aware of the optimization features that are disabled by default and how they can re-enable them if their environment supports it.
Consider adding a section in the project's README or developer documentation that outlines known compatibility issues and their workarounds, including this specific change regarding optipng
.
Jest Coverage ReportTotal coverage
Report generated by 🧪jest coverage report action from caa8b4f |
Ticket Link
Related Links
Description
optipng-bin module not found error on M1 & M2 armx64
Steps to Reproduce / Test
Checklist
yarn test
passesGIF's
Live Link
Summary by CodeRabbit
optipng
optimization to prevent errors on Mac M1 & M2 environments. Instructions provided for re-enabling if desired.