Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/optipng module issue on armx64 #198

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix/optipng module issue on armx64 #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internals/webpack/webpack.config.base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,11 @@ module.exports = (options) => ({
interlaced: false
},
optipng: {
optimizationLevel: 7
enabled: false
// NOTE: optipng is disabled as it causes errors in some Mac M1 & M2 environments
// Try enabling it in your environment by switching the config to:
// enabled: true,
// optimizationLevel: 7
Comment on lines +138 to +142
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling optipng optimization for Mac M1 & M2 environments is a pragmatic solution to ensure compatibility across different hardware architectures. However, it's important to document this change prominently in the project's README or developer documentation, not just within the code comments. This ensures that all developers are aware of the optimization features that are disabled by default and how they can re-enable them if their environment supports it.

Consider adding a section in the project's README or developer documentation that outlines known compatibility issues and their workarounds, including this specific change regarding optipng.

},
pngquant: {
quality: [0.65, 0.9],
Expand Down
Loading