Proposal for Mantle USDe market #85
Conversation
…ess - 0x2127338F0ff71Ecc779dce407D95C7D32f7C5F45
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| error InvalidInt256(); | ||
|
|
||
| /// @notice Version of the price feed | ||
| uint public constant override version = 1; |
Check warning
Code scanning / Semgrep OSS
A constant name is not in UPPER_CASE like other constant variables. Warning
| constructor(address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
| underlyingPriceFeed = underlyingPriceFeed_; | ||
| decimals = decimals_; | ||
| description = description_; | ||
|
|
||
| uint8 underlyingPriceFeedDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
| // Note: Solidity does not allow setting immutables in if/else statements | ||
| shouldUpscale = underlyingPriceFeedDecimals < decimals_ ? true : false; | ||
| rescaleFactor = (shouldUpscale | ||
| ? signed256(10 ** (decimals_ - underlyingPriceFeedDecimals)) | ||
| : signed256(10 ** (underlyingPriceFeedDecimals - decimals_)) | ||
| ); | ||
| } |
Check warning
Code scanning / Semgrep OSS
There're no sanity checks for the constructor argument decimals_. Warning
| constructor(address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
| underlyingPriceFeed = underlyingPriceFeed_; | ||
| decimals = decimals_; | ||
| description = description_; | ||
|
|
||
| uint8 underlyingPriceFeedDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
| // Note: Solidity does not allow setting immutables in if/else statements | ||
| shouldUpscale = underlyingPriceFeedDecimals < decimals_ ? true : false; | ||
| rescaleFactor = (shouldUpscale | ||
| ? signed256(10 ** (decimals_ - underlyingPriceFeedDecimals)) | ||
| : signed256(10 ** (underlyingPriceFeedDecimals - decimals_)) | ||
| ); | ||
| } |
Check warning
Code scanning / Semgrep OSS
There're no sanity checks for the constructor argument description_. Warning
| constructor(address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
| underlyingPriceFeed = underlyingPriceFeed_; | ||
| decimals = decimals_; | ||
| description = description_; | ||
|
|
||
| uint8 underlyingPriceFeedDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
| // Note: Solidity does not allow setting immutables in if/else statements | ||
| shouldUpscale = underlyingPriceFeedDecimals < decimals_ ? true : false; | ||
| rescaleFactor = (shouldUpscale | ||
| ? signed256(10 ** (decimals_ - underlyingPriceFeedDecimals)) | ||
| : signed256(10 ** (underlyingPriceFeedDecimals - decimals_)) | ||
| ); | ||
| } |
Check warning
Code scanning / Semgrep OSS
There're no sanity checks for the constructor argument underlyingPriceFeed_. Warning
| constructor(address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
| underlyingPriceFeed = underlyingPriceFeed_; | ||
| decimals = decimals_; | ||
| description = description_; | ||
|
|
||
| uint8 underlyingPriceFeedDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
| // Note: Solidity does not allow setting immutables in if/else statements | ||
| shouldUpscale = underlyingPriceFeedDecimals < decimals_ ? true : false; | ||
| rescaleFactor = (shouldUpscale | ||
| ? signed256(10 ** (decimals_ - underlyingPriceFeedDecimals)) | ||
| : signed256(10 ** (underlyingPriceFeedDecimals - decimals_)) | ||
| ); | ||
| } |
Check warning
Code scanning / Semgrep OSS
Consider making costructor payable to save gas. Warning
…m:woof-software/comet into woof-software/deploy-compound-mantle-usde
Co-authored-by: dmitriy-woof-software <dmitriy@woof.software> Co-authored-by: GitHub Actions Bot <> Co-authored-by: Dmitriy Babenko <159453675+dmitriy-woof-software@users.noreply.github.com>
…are/deploy-compound-mantle-usde
dmitriy-woof-software
force-pushed
the
main
branch
from
b921cbf to
01ce0c4
Compare
No description provided.