forked from compound-finance/comet
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for Mantle USDe market #85
Open
MishaShWoof
wants to merge
38
commits into
main
Choose a base branch
from
woof-software/deploy-compound-mantle-usde
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
f9bcb26
wip
MishaShWoof b6697bc
wip
MishaShWoof 74b436b
wip
MishaShWoof 6e4a0d7
wip
MishaShWoof 9fbe1b2
wip: working scenarios
MishaShWoof ed0dde2
feat: migration and fix for the redstone oracles
MishaShWoof 6433f55
fix: pr link
MishaShWoof 7fb3137
feat: udpate safe libs. deploy pauseGuardian for Mantel network. addr…
dmitriy-woof-software 2205595
update caps and speeds to zero
dmitriy-woof-software 45dab4c
Merge branch 'main' into woof-software/deploy-compound-mantle-usde
dmitriy-woof-software 4f97f07
feat: update description
dmitriy-woof-software 4462c80
remove safe lib yarn.lock update
dmitriy-woof-software 62d748b
feat: update description
dmitriy-woof-software fccd37c
feat: update description
dmitriy-woof-software d833496
feat: update price feeds
dmitriy-woof-software f2ce5fa
feat: update price feeds
dmitriy-woof-software 5ec3b62
feat: update MANTLE to MNT token name
dmitriy-woof-software 4a3a857
add mantle into hardhat config
dmitriy-woof-software 782522d
wip: deployment
dmitriy-woof-software c07ada8
Modified deployment roots from GitHub Actions
15c7f58
feat: add caps, speeds and update doc
dmitriy-woof-software d15c67d
feat: update seacrest
dmitriy-woof-software ca9253a
feat: update enact-migration
dmitriy-woof-software fe24058
fix: changes after audit
MishaShWoof f9a86e1
feat: add comments
dmitriy-woof-software 197dc91
Merge branch 'main' into woof-software/deploy-compound-mantle-usde
dmitriy-woof-software e862fb9
feat: update config for deployment
dmitriy-woof-software 34e4ab9
Merge branch 'woof-software/deploy-compound-mantle-usde' of github.co…
dmitriy-woof-software 739c6df
Modified deployment roots from GitHub Actions
2f2257a
feat: update roots
dmitriy-woof-software 0129b6c
Modified deployment roots from GitHub Actions
39b1986
update caps and speeds
dmitriy-woof-software 0a13d2f
feat: update config for mantle scenarios
dmitriy-woof-software d70364b
feat: comment USDS ENS, as it is not executed yet
dmitriy-woof-software 9085b8a
Proposal for Mainnet USDS market (#942)
MishaShWoof d34ec5f
Merge branch 'main' of github.com:woof-software/comet into woof-softw…
MishaShWoof 32be792
fix: update
MishaShWoof 86bc48d
Modified migration from GitHub Actions
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
contracts/pricefeeds/ScalingPriceFeedWithCustomDescription.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
| pragma solidity 0.8.15; | ||
|
|
||
| import "../vendor/@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol"; | ||
| import "../IPriceFeed.sol"; | ||
|
|
||
| /** | ||
| * @title Scaling price feed | ||
| * @notice A custom price feed that scales up or down the price received from an underlying price feed and returns the result | ||
| * @author Compound | ||
| */ | ||
| contract ScalingPriceFeedWithCustomDescription is IPriceFeed { | ||
| /** Custom errors **/ | ||
| error InvalidInt256(); | ||
|
|
||
| /// @notice Version of the price feed | ||
| uint public constant override version = 1; | ||
|
|
||
| /// @notice Description of the price feed | ||
| string public description; | ||
|
|
||
| /// @notice Number of decimals for returned prices | ||
| uint8 public immutable override decimals; | ||
|
|
||
| /// @notice Underlying price feed where prices are fetched from | ||
| address public immutable underlyingPriceFeed; | ||
|
|
||
| /// @notice Whether or not the price should be upscaled | ||
| bool internal immutable shouldUpscale; | ||
|
|
||
| /// @notice The amount to upscale or downscale the price by | ||
| int256 internal immutable rescaleFactor; | ||
|
|
||
| /** | ||
| * @notice Construct a new scaling price feed | ||
| * @param underlyingPriceFeed_ The address of the underlying price feed to fetch prices from | ||
| * @param decimals_ The number of decimals for the returned prices | ||
| **/ | ||
| constructor(address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
| underlyingPriceFeed = underlyingPriceFeed_; | ||
| decimals = decimals_; | ||
| description = description_; | ||
|
|
||
| uint8 underlyingPriceFeedDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
| // Note: Solidity does not allow setting immutables in if/else statements | ||
| shouldUpscale = underlyingPriceFeedDecimals < decimals_ ? true : false; | ||
| rescaleFactor = (shouldUpscale | ||
| ? signed256(10 ** (decimals_ - underlyingPriceFeedDecimals)) | ||
| : signed256(10 ** (underlyingPriceFeedDecimals - decimals_)) | ||
| ); | ||
| } | ||
|
Comment on lines
+39
to
+51
Check warning Code scanning / Semgrep OSS There're no sanity checks for the constructor argument decimals_. Warning
There're no sanity checks for the constructor argument decimals_.
Comment on lines
+39
to
+51
Check warning Code scanning / Semgrep OSS There're no sanity checks for the constructor argument description_. Warning
There're no sanity checks for the constructor argument description_.
Comment on lines
+39
to
+51
Check warning Code scanning / Semgrep OSS There're no sanity checks for the constructor argument underlyingPriceFeed_. Warning
There're no sanity checks for the constructor argument underlyingPriceFeed_.
Comment on lines
+39
to
+51
Check warning Code scanning / Semgrep OSS Consider making costructor payable to save gas. Warning
Consider making costructor payable to save gas.
|
||
|
|
||
| /** | ||
| * @notice Price for the latest round | ||
| * @return roundId Round id from the underlying price feed | ||
| * @return answer Latest price for the asset in terms of ETH | ||
| * @return startedAt Timestamp when the round was started; passed on from underlying price feed | ||
| * @return updatedAt Timestamp when the round was last updated; passed on from underlying price feed | ||
| * @return answeredInRound Round id in which the answer was computed; passed on from underlying price feed | ||
| **/ | ||
| function latestRoundData() override external view returns ( | ||
| uint80 roundId, | ||
| int256 answer, | ||
| uint256 startedAt, | ||
| uint256 updatedAt, | ||
| uint80 answeredInRound | ||
| ) { | ||
| (uint80 roundId_, int256 price, uint256 startedAt_, uint256 updatedAt_, uint80 answeredInRound_) = AggregatorV3Interface(underlyingPriceFeed).latestRoundData(); | ||
| return (roundId_, scalePrice(price), startedAt_, updatedAt_, answeredInRound_); | ||
| } | ||
|
|
||
| function signed256(uint256 n) internal pure returns (int256) { | ||
| if (n > uint256(type(int256).max)) revert InvalidInt256(); | ||
| return int256(n); | ||
| } | ||
|
|
||
| function scalePrice(int256 price) internal view returns (int256) { | ||
| int256 scaledPrice; | ||
| if (shouldUpscale) { | ||
| scaledPrice = price * rescaleFactor; | ||
| } else { | ||
| scaledPrice = price / rescaleFactor; | ||
| } | ||
| return scaledPrice; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / Semgrep OSS
A constant name is not in UPPER_CASE like other constant variables. Warning