Skip to content

Commit

Permalink
updated from reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
kungfucraig committed Dec 17, 2024
1 parent 6eb9bd5 commit bc68b0c
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,7 @@ message BasicReport {
};

// Resource name.
string name = 1 [
(google.api.field_behavior) = IMMUTABLE,
(google.api.field_behavior) = IDENTIFIER
];
string name = 1 [(google.api.field_behavior) = IDENTIFIER];

// Human readable title of the report.
string title = 2 [(google.api.field_behavior) = IMMUTABLE];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,27 +55,31 @@ message GetBasicReportRequest {

// Request mesage for 'GetListBasicReport' method
message ListBasicReportsRequest {
string parent = 1 [(google.api.resource_reference) = {
type: "reporting.halo-cmm.org/MeasurementConsumer"
}];

// Message for specifying filters for listing BasicReports.
message Filter {
// Return BasicReports that were created after this time.
google.protobuf.Timestamp created_after = 1
[(google.api.field_behavior) = REQUIRED];
}
// Filter for the list of BasicReports
Filter filter = 1 [(google.api.field_behavior) = OPTIONAL];
Filter filter = 2 [(google.api.field_behavior) = OPTIONAL];

// The maximum number of basic reports to return. The service may return fewer
// than this value.
// If unspecified, at most 10 basic reports will be returned.
// The maximum value is 25; values above 25 will be coerced to 25.
int32 page_size = 2 [(google.api.field_behavior) = OPTIONAL];
int32 page_size = 3 [(google.api.field_behavior) = OPTIONAL];

// A page token, received from a previous `ListBasicReports` call.
// Provide this to retrieve the subsequent page.
//
// When paginating, all other parameters provided to `ListBasicReports` must
// match the call that provided the page token.
string page_token = 3 [(google.api.field_behavior) = OPTIONAL];
string page_token = 4 [(google.api.field_behavior) = OPTIONAL];
}

// Response message for 'ListBasicReports' method.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ message ImpressionQualificationFilter {
};

// Resource name.
string name = 1 [
(google.api.field_behavior) = IMMUTABLE,
(google.api.field_behavior) = IDENTIFIER
];
string name = 1 [(google.api.field_behavior) = IDENTIFIER];

// Specifies the filter criteria
ImpressionQualificationFilterSpec filter_spec = 2 [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ message ImpressionQualificationFilterSpec {
// Defines how filters related to Reporting Media Types.
//
// Generally, a Filter with a given Filter Type is applied to a Reporting Unit
// when the type matches that of the Reporting Media Type. However, a filer
// when the type matches that of the Reporting Media Type. However, a filter
// with type CROSS_MEDIA is applied when multiple Reporting Media Types are
// specified.
enum FilterType {
Expand Down Expand Up @@ -70,6 +70,7 @@ message ImpressionQualificationFilterSpec {

// Specify a percent as a fraction or as a quantile
message Percent {
// Required
oneof value {
// The fraction
float fraction = 1 [(google.api.field_behavior) = IMMUTABLE];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ message ReportingUnit {
//
// For use with BasicReport these must be Data Provider resource names
// For use with AdvancedReport these must be Reporting Set resource names
repeated string components = 2 [
repeated string components = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.field_behavior) = IMMUTABLE,
(google.api.resource_reference) = { type: "*" }
];

// Display names of the resource referenced by the Reporting Unit
repeated string display_name = 3 [
repeated string display_name = 2 [
(google.api.field_behavior) = OUTPUT_ONLY,
(google.api.field_behavior) = IMMUTABLE
];
Expand All @@ -49,15 +49,15 @@ message ReportingUnit {
// policy. For exmaple if VIDEO and DISPLAY are specified and an
// MRC filter is available for both then the MRC filter, as it applies to
// the specific media type, could be applied.
repeated ReportingMediaType reporting_media_types = 4 [
repeated MediaType reporting_media_types = 3 [
(google.api.field_behavior) = REQUIRED,
(google.api.field_behavior) = IMMUTABLE
];
}

// ReportingMediaType is used to designate how reporting artifacts
// MediaType is used to designate how reporting artifacts
// should be interpreted for reporting.
enum ReportingMediaType {
enum MediaType {
// Default value. Unused.
REPORTING_MEDIA_TYPE_UNSPECIFIED = 0;
// Interpret a set of arifacts as Video
Expand Down

0 comments on commit bc68b0c

Please sign in to comment.