Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ietestform journal feedback #111

Merged
merged 4 commits into from
Aug 6, 2019
Merged

Conversation

kbjarkefur
Copy link
Contributor

Two changes based on feedback from the Stata Journal reveiw:

  • use using instead of surveyform(). Backward compatibility is built in.
  • rename report() to reportsave(). Backward compatibility is automatic thanks to option name abbreviation.

I have tested this and the changes are not that big. But if someone else could test this too, then that would be great! @roshni13khincha , could you test since you have used this command before?

Copy link
Collaborator

@luizaandrade luizaandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I duplicated my comment. Ignore this one and read the following.

@luizaandrade
Copy link
Collaborator

I have tested the new features and they work. However, I've come across two minor things:

  1. If a file extension is not specified for the report, the command will save it without one, and no warning/error message is given:
    image

  2. The date option is not working

  3. Special characters (argh) may be imported with the incorrect encoding -- not sure there is a way to fix this, really, as one would have to be able to tell how the file is encoded before importing.
    image

I think I've fixed 1 & 2 in 469e56c, so I'm approving this and opening an issue for 3in #112 that we may look into later if anyone has ideas on how to fix.

@kbjarkefur
Copy link
Contributor Author

Thanks for fixing 1 & 2. I will comment on 3 in the issue you opened.

I will go ahead and merge now.

@kbjarkefur kbjarkefur merged commit df42279 into develop Aug 6, 2019
@kbjarkefur kbjarkefur deleted the ietestform-journal-feedback branch August 6, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants