core: Remove some constructors from Builder
#3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructors `after`, `before`, `at_start`, and `at_end` are removed as users should use the equivalent `InsertPoint` constructors instead. These constructors are currently preventing the `Rewriter` to inherit `Builder`. stack-info: PR: #3702, branch: math-fehr/stack/6
math-fehr
force-pushed
the
math-fehr/stack/6
branch
from
8ca2b96 to
4cb9ea2
Compare
math-fehr
force-pushed
the
math-fehr/stack/5
branch
from
d63133c to
614e4f8
Compare
This was referenced Jan 6, 2025
compor
approved these changes
Jan 6, 2025
math-fehr
added a commit
that referenced
this pull request
Jan 6, 2025
The constructors `after`, `before`, `at_start`, and `at_end` are removed as users should use the equivalent `InsertPoint` constructors instead. These constructors are currently preventing the `Rewriter` to inherit `Builder`. stack-info: PR: #3702, branch: math-fehr/stack/6
math-fehr
force-pushed
the
math-fehr/stack/6
branch
from
4cb9ea2 to
63748c2
Compare
alexarice
approved these changes
Jan 6, 2025
superlopuh
approved these changes
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## math-fehr/stack/5 #3702 +/- ##
=====================================================
- Coverage 91.32% 91.31% -0.01%
=====================================================
Files 467 467
Lines 58506 58488 -18
Branches 5643 5643
=====================================================
- Hits 53430 53411 -19
Misses 3626 3626
- Partials 1450 1451 +1 ☔ View full report in Codecov by Sentry. |
math-fehr
force-pushed
the
math-fehr/stack/6
branch
from
63748c2 to
05c7401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Builder#3702core: Remove some constructors from
BuilderThe constructors
after,before,at_start, andat_endare removedas users should use the equivalent
InsertPointconstructors instead.These constructors are currently preventing the
Rewriterto inheritBuilder.