core: Refactor some methods using BlockInsertPoint #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
force-pushed
the
math-fehr/stack/7
branch
from
127af6d to
8075761
Compare
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
51c38b8 to
d23065a
Compare
This was referenced Jan 6, 2025
math-fehr
added a commit
that referenced
this pull request
Jan 6, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
d23065a to
b1c53cd
Compare
math-fehr
added a commit
that referenced
this pull request
Jan 6, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
b1c53cd to
d36a076
Compare
math-fehr
added a commit
that referenced
this pull request
Jan 6, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
d36a076 to
1424679
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## math-fehr/stack/7 #3704 +/- ##
==================================================
Coverage 91.25% 91.25%
==================================================
Files 459 459
Lines 57351 57328 -23
Branches 5533 5530 -3
==================================================
- Hits 52333 52314 -19
+ Misses 3593 3591 -2
+ Partials 1425 1423 -2 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Jan 6, 2025
superlopuh
approved these changes
Jan 6, 2025
compor
approved these changes
Jan 6, 2025
math-fehr
force-pushed
the
math-fehr/stack/7
branch
from
9efdda7 to
f4bc3bb
Compare
math-fehr
added a commit
that referenced
this pull request
Jan 6, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
1424679 to
2541571
Compare
math-fehr
force-pushed
the
math-fehr/stack/7
branch
from
f4bc3bb to
bd3bca3
Compare
math-fehr
added a commit
that referenced
this pull request
Jan 6, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
2541571 to
41cf86c
Compare
math-fehr
added a commit
that referenced
this pull request
Jan 6, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
alexarice
approved these changes
Jan 8, 2025
math-fehr
added a commit
that referenced
this pull request
Jan 13, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
added a commit
that referenced
this pull request
Jan 20, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
added a commit
that referenced
this pull request
Jan 20, 2025
This factors out quite a few methods in the `Builder`, `Rewriter`, and `PatternRewriter`. stack-info: PR: #3704, branch: math-fehr/stack/8
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
41cf86c to
3125fc1
Compare
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
3125fc1 to
8d1484c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
core: Refactor some methods using BlockInsertPoint
This factors out quite a few methods in the
Builder,Rewriter,and
PatternRewriter.