XWIKI-21521: DefaultSkin form should be accessible #2642
Conversation
* Wrapped the pretty name in a label which is bound to the form field with its `for` attribute
| @@ -149,6 +149,7 @@ | |||
| ((( | |||
| {{html}}<button class="btn btn-default btn-xs">$services.icon.renderHTML('cross')</button>{{/html}} | |||
| ))) | |||
| ))) | |||
There was a problem hiding this comment.
I cannot see any code that adds the corresponding (((, was this missing before?
There was a problem hiding this comment.
Sorry, it was a mistake, I don't know what I did here...
Addressed in 18cc897 👍
* Fixed a mistake
| @@ -80,7 +80,7 @@ | |||
| #set ($class = $doc.getObject($className).xWikiClass) | |||
| #foreach ($prop in $class.properties) | |||
| #if ($prop.classType != 'TextArea') | |||
| ; $services.rendering.escape($prop.prettyName, 'xwiki/2.1') | |||
| ; {{html}}<label for="${className}_0_$escapetool.xml($prop.name)">$escapetool.xml($prop.prettyName)</label>{{/html}} | |||
There was a problem hiding this comment.
It's not necessarily the object at index 0 is it? Chances are low but we could imagine that the retrieved object has another index no?
There was a problem hiding this comment.
I just tried using the $prop.number attribute to fill up this id.
Seems like the number used in the ids is not the same, and so it doesn't match.
From what I could see in this form, all properties used 0 (because they were the only ones with their name, no duplicate names? ).
I'll be leaving the PR as is for now.
There was a problem hiding this comment.
I just tried using the $prop.number attribute to fill up this id.
Yes it won't work with $prop.number: as the name suggest it's the index of the property. Here the 0 is the index of the xobject itself.
There was a problem hiding this comment.
Addressed in afe5ee9 👍
Here is the result with the updated template:
As we can see, all attribute values reference to the right nodes.
* Replaced the hard-coded reference with a call to the object number.
* Wrapped the pretty name in a label which is bound to the form field with its `for` attribute * Replaced the hard-coded reference with a call to the object number.
* Wrapped the pretty name in a label which is bound to the form field with its `for` attribute * Replaced the hard-coded reference with a call to the object number.
Jira
https://jira.xwiki.org/browse/XWIKI-21521
PR Changes
forattributeNote
View
We can see on the screenshot below that an axe-core analysis of the page does not return any violation anymore.
